Pig
  1. Pig
  2. PIG-2447

piggybank: get hive dependency from maven

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.2, 0.10.0, 0.11
    • Component/s: build, piggybank
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Tarball download slows down and occasionally fails CI builds. Hive is now available from maven.

      1. PIG-2447.1.patch
        4 kB
        Thomas Weise
      2. PIG-2447.2.patch
        4 kB
        Thomas Weise
      3. PIG-2447.patch
        4 kB
        Thomas Weise

        Activity

        Daniel Dai made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Daniel Dai made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.10 [ 12316246 ]
        Fix Version/s 0.9.2 [ 12318248 ]
        Resolution Fixed [ 1 ]
        Hide
        Daniel Dai added a comment -

        Also commit to 0.9/0.10 as per Thomas request.

        Show
        Daniel Dai added a comment - Also commit to 0.9/0.10 as per Thomas request.
        Thomas Weise made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Thomas Weise added a comment -

        Thanks Gianmarco - please commit to 0.10 also, we have seen intermittent issues with the hive download that fail our 0.9 and 0.10 CI builds, so we would like to have this change in the branch.

        Show
        Thomas Weise added a comment - Thanks Gianmarco - please commit to 0.10 also, we have seen intermittent issues with the hive download that fail our 0.9 and 0.10 CI builds, so we would like to have this change in the branch.
        Hide
        Gianmarco De Francisci Morales added a comment -

        I forgot to say: feel free to reopen the issue if you feel this patch is needed in the 0.10 branch.
        Thanks Thomas!

        Show
        Gianmarco De Francisci Morales added a comment - I forgot to say: feel free to reopen the issue if you feel this patch is needed in the 0.10 branch. Thanks Thomas!
        Gianmarco De Francisci Morales made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.10 [ 12316246 ]
        Fix Version/s 0.9.2 [ 12318248 ]
        Resolution Fixed [ 1 ]
        Hide
        Gianmarco De Francisci Morales added a comment -

        Patch looks good.
        Committed to trunk.
        Is there a compelling reason to put the patch also in the 0.10 branch?

        Note: Hive version bumped from 0.4.1 to 0.8 with this patch.

        Show
        Gianmarco De Francisci Morales added a comment - Patch looks good. Committed to trunk. Is there a compelling reason to put the patch also in the 0.10 branch? Note: Hive version bumped from 0.4.1 to 0.8 with this patch.
        Thomas Weise made changes -
        Attachment PIG-2447.2.patch [ 12509761 ]
        Hide
        Thomas Weise added a comment -

        Rebased patch.

        Show
        Thomas Weise added a comment - Rebased patch.
        Thomas Weise made changes -
        Attachment PIG-2447.1.patch [ 12508553 ]
        Hide
        Thomas Weise added a comment -

        Updated patch. The Hive ColumnarStruct API has changed (getField no longer has a org.apache.hadoop.io.Text nullSequence parameter). I removed the member declaration as well.

        Show
        Thomas Weise added a comment - Updated patch. The Hive ColumnarStruct API has changed (getField no longer has a org.apache.hadoop.io.Text nullSequence parameter). I removed the member declaration as well.
        Hide
        Gianmarco De Francisci Morales added a comment -

        Generally looks good.
        A couple of comments:
        Is the modification to HiveColumnarLoader.java intended and related to this patch?
        Could you delete, rather than comment, the code that you removed in the path creation?

        Show
        Gianmarco De Francisci Morales added a comment - Generally looks good. A couple of comments: Is the modification to HiveColumnarLoader.java intended and related to this patch? Could you delete, rather than comment, the code that you removed in the path creation?
        Thomas Weise made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Thomas Weise added a comment -

        piggybank unit tests:

        BUILD SUCCESSFUL
        Total time: 12 minutes 48 seconds

        Show
        Thomas Weise added a comment - piggybank unit tests: BUILD SUCCESSFUL Total time: 12 minutes 48 seconds
        Thomas Weise made changes -
        Attachment PIG-2447.patch [ 12508336 ]
        Thomas Weise made changes -
        Field Original Value New Value
        Fix Version/s 0.10 [ 12316246 ]
        Fix Version/s 0.9.2 [ 12318248 ]
        Fix Version/s 0.11 [ 12318878 ]
        Thomas Weise created issue -

          People

          • Assignee:
            Thomas Weise
            Reporter:
            Thomas Weise
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development