[PIG-2362] Rework Ant build.xml to use macrodef instead of antcall

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.12.0
• Assignee: Gianmarco De Francisci Morales
• Reporter: Gianmarco De Francisci Morales
• Created: 14/Nov/11 16:09
• Updated: 14/Oct/13 16:46
• Resolved: 04/Jan/13 09:33

Description

Antcall is evil: http://www.build-doctor.com/2008/03/13/antcall-is-evil/
We'd better use macrodef and let Ant build a clean dependency graph.
http://ant.apache.org/manual/Tasks/macrodef.html

Right now we do like this:

<target name="buildAllJars">
  <antcall target="buildJar">
    <param name="build.dir" value="jar-A"/>
  </antcall>
  <antcall target="buildJar">
    <param name="build.dir" value="jar-B"/>
  </antcall>
  <antcall target="buildJar">
    <param name="build.dir" value="jar-C"/>
  </antcall>
</target>
<target name="buildJar">
  <jar destfile="target/${build.dir}.jar" basedir="${build.dir}/classfiles"/>
</target>

But it would be better if we did like this:

<target name="buildAllJars">
  <buildJar build.dir="jar-A"/>
  <buildJar build.dir="jar-B"/>
  <buildJar build.dir="jar-C"/>
</target>

<macrodef name="buildJar">
  <attribute name="build.dir"/>
  <jar destfile="target/${build.dir}.jar" basedir="${build.dir}/classfiles"/>
</macrodef>

Issue Links

• is superceded by: PIG-2599 Mavenize Pig