Pig
  1. Pig
  2. PIG-234

fix synchronization around staleCount in DataCollector

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.1.0
    • Component/s: impl
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description


      DataCollector uses synchronized statements on staleCount, but the staleCount reference changes! I'm proposing it switch to use the concurrent package Lock and condition to manage staleness.

        Activity

        Hide
        Olga Natkovich added a comment -

        This code will no longer be used after execution pipeline rework is completed

        Show
        Olga Natkovich added a comment - This code will no longer be used after execution pipeline rework is completed
        Hide
        Chad Whipkey added a comment -

        Okay, if you are not going to be using this code then I think it's okay to close this bug. I will look at the PigType trunk in the future before making submissions. Thanks!

        Show
        Chad Whipkey added a comment - Okay, if you are not going to be using this code then I think it's okay to close this bug. I will look at the PigType trunk in the future before making submissions. Thanks!
        Hide
        Pi Song added a comment -

        Good eyes!!! Another bug from auto-boxing!!!

        However:-
        1. Currently we only run local execution engine in single-threaded mode so this buggy synchronization code doesn't cause any problem.
        2. We are removing all of those spec classes as we are moving to the new pipeline design. Please have a look at PigType trunk. We need more people like you to help!!!

        Show
        Pi Song added a comment - Good eyes!!! Another bug from auto-boxing!!! However:- 1. Currently we only run local execution engine in single-threaded mode so this buggy synchronization code doesn't cause any problem. 2. We are removing all of those spec classes as we are moving to the new pipeline design. Please have a look at PigType trunk. We need more people like you to help!!!
        Hide
        Chad Whipkey added a comment -

        Please code review. This is my first patch ever so let me know if I should do things differently.

        Show
        Chad Whipkey added a comment - Please code review. This is my first patch ever so let me know if I should do things differently.

          People

          • Assignee:
            Chad Whipkey
            Reporter:
            Chad Whipkey
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development