[PIG-2230] Display empty param instead of usage error message

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.8.0, 0.9.0
• Fix Version/s: 0.10.0, 0.11
• Labels: newbie

Release Note

I would like to port this to 0.10. We have many users running into this issue and the changes are very low risk.

I am planning to run tests and commit if all goes well

• Assignee: xuting zhao
• Reporter: Anitha Raju
• Created: 22/Aug/11 05:18
• Updated: 26/Apr/12 20:33
• Resolved: 07/Nov/11 18:49

Description

Hi,

When empty param is passed in the command line, it prints usage error. Even if the value of the param is a space " " it shows the usage error.

---------------
$ pig -useversion 0.9 -param test=" " test.pig
USING: /grid/0/gs/pig/0.9
2011-08-22 05:06:08,538 [main] INFO org.apache.pig.Main - Logging error messages to: /homes/anithar/pig_1313989568534.log

Apache Pig version 0.9.0.1105251322 (r1127671)
compiled May 25 2011, 20:22:22

USAGE: Pig [options] [-] : Run interactively in grunt shell.
Pig [options] -e[xecute] cmd [cmd ...] : Run cmd(s).
Pig [options] [-f[ile]] file : Run cmds found in file.
options include:
-4, -log4jconf - Log4j configuration file, overrides log conf
-b, -brief - Brief logging (no timestamps)
-c, -check - Syntax check
-d, -debug - Debug level, INFO is default
-e, -execute - Commands to execute (within quotes)
-f, -file - Path to the script to execute
-g, -embedded - ScriptEngine classname or keyword for the ScriptEngine
-h, -help - Display this message. You can specify topic to get help for that topic.
properties is the only topic currently supported: -h properties.
-i, -version - Display version information
-l, -logfile - Path to client side log file; default is current working directory.
-m, -param_file - Path to the parameter file
-p, -param - Key value pair of the form param=val
-r, -dryrun - Produces script with substituted parameters. Script is not executed.
-t, -optimizer_off - Turn optimizations off. The following values are supported:
SplitFilter - Split filter conditions
MergeFilter - Merge filter conditions
PushUpFilter - Filter as early as possible
PushDownForeachFlatten - Join or explode as late as possible
ColumnMapKeyPrune - Remove unused data
LimitOptimizer - Limit as early as possible
AddForEach - Add ForEach to remove unneeded columns
MergeForEach - Merge adjacent ForEach
LogicalExpressionSimplifier - Combine multiple expressions
All - Disable all optimizations
All optimizations are enabled by default. Optimization values are case insensitive.
-v, -verbose - Print all error messages to screen
-w, -warning - Turn warning logging on; also turns warning aggregation off
-x, -exectype - Set execution mode: local|mapreduce, default is mapreduce.
-F, -stop_on_failure - Aborts execution on the first failed job; default is off
-M, -no_multiquery - Turn multiquery optimization off; default is on
-P, -propertyFile - Path to property file
-------------------

Instead of printing the usage error, can you show which param is empty.

Regards,
Anitha