Pig
  1. Pig
  2. PIG-2216

deprecate use of type in as clause of foreach statement

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      In the as clause of foreach statement, type can be specified, but that type is actually not used (ie, it does not result in a cast). This behavior is misleading.

      F = foreach INP generate c1 as (name : chararray);
      

      Pig 0.8 produces an error if c1 in above example is not of same type as specified in the as clause.
      In 0.9, that check seems to have been lost in the parser migration. It also results in the logical plan thinking that the type of c1 is that specified in the as clause. That can cause errors such as ClassCastException.

      One way to be consistent here would have been to add cast for the as clause as well. But having two ways to cast complicates things. So long term, I think the use of types in as clause should be removed.

      For 0.10, i think the check present in 0.8 should be added back, and the syntax should be deprecated (resulting in a warning when used).

        Issue Links

          Activity

          Hide
          Daniel Dai added a comment -

          This is the same issue of PIG-2315. Mark this issue as duplicate.

          Show
          Daniel Dai added a comment - This is the same issue of PIG-2315 . Mark this issue as duplicate.

            People

            • Assignee:
              Unassigned
              Reporter:
              Thejas M Nair
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development