Pig
  1. Pig
  2. PIG-2182

Add more append support to DataByteArray

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I was recently writing a UDF to use a DataByteArray similar to CONCAT and thought it would be convenient if DBA supported more append options similar to Appendable and also that you can string them together if you wish as in dba.append("foo").append("bar").

      1. PIG-2182.patch
        2 kB
        Grant Ingersoll
      2. PIG-2182-2.patch
        3 kB
        Daniel Dai

        Activity

        Hide
        Daniel Dai added a comment -

        Patch committed 0.10/trunk. Thanks Grant!

        Show
        Daniel Dai added a comment - Patch committed 0.10/trunk. Thanks Grant!
        Hide
        Daniel Dai added a comment -

        Add test cases.

        Show
        Daniel Dai added a comment - Add test cases.
        Hide
        Alan Gates added a comment -

        As long as the tests pass consistently, no objections.

        Show
        Alan Gates added a comment - As long as the tests pass consistently, no objections.
        Hide
        Daniel Dai added a comment -

        I run through the tests. I checked the patch seems nothing will break existing code. I plan to commit the patch, objection?

        Show
        Daniel Dai added a comment - I run through the tests. I checked the patch seems nothing will break existing code. I plan to commit the patch, objection?
        Hide
        Thejas M Nair added a comment -

        I also verified that adding new functions to an existing class is a binary compatible change - http://java.sun.com/docs/books/jls/second_edition/html/binaryComp.doc.html

        Show
        Thejas M Nair added a comment - I also verified that adding new functions to an existing class is a binary compatible change - http://java.sun.com/docs/books/jls/second_edition/html/binaryComp.doc.html
        Hide
        Alan Gates added a comment -

        Reviewing this patch it looks fine. But every time I run the tests on it I see quite a few test failures. The failures are not repeatable, nor is it the same tests failing. But it's frequent enough that I'm convinced something here is causing an issue. I'll keep looking into it, but at this point I want to hold off committing this patch.

        Show
        Alan Gates added a comment - Reviewing this patch it looks fine. But every time I run the tests on it I see quite a few test failures. The failures are not repeatable, nor is it the same tests failing. But it's frequent enough that I'm convinced something here is causing an issue. I'll keep looking into it, but at this point I want to hold off committing this patch.
        Hide
        Alan Gates added a comment -

        Reviewing this patch, seriously belatedly.

        Show
        Alan Gates added a comment - Reviewing this patch, seriously belatedly.
        Hide
        Grant Ingersoll added a comment -

        adds appends and has append return a DataByteArray.

        Show
        Grant Ingersoll added a comment - adds appends and has append return a DataByteArray.

          People

          • Assignee:
            Grant Ingersoll
            Reporter:
            Grant Ingersoll
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development