Pig
  1. Pig
  2. PIG-213

Non-static Log objects in org.apache.pig.data.* classes are inefficient

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.1.0
    • Fix Version/s: 0.1.0
    • Component/s: impl
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      LogFactory.getLog called from the constructor of Tuple accounts for significant percentage of my job's running time. The proposed fix is to make the Log fields static (which is generally standard practice).

      1. logging.patch
        3 kB
        Vadim Geshel

        Activity

        Vadim Geshel created issue -
        Vadim Geshel made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Vadim Geshel made changes -
        Attachment logging.patch [ 12380527 ]
        Hide
        Benjamin Reed added a comment -

        +1 Good catch.

        Show
        Benjamin Reed added a comment - +1 Good catch.
        Hide
        Mathieu Poumeyrol added a comment -

        Yes, I actualy had a similar patch ready. I measured a 2 figures percentage of time spent on the logger instantiation on some processes...

        Show
        Mathieu Poumeyrol added a comment - Yes, I actualy had a similar patch ready. I measured a 2 figures percentage of time spent on the logger instantiation on some processes...
        Hide
        Alan Gates added a comment -

        Patch checked in at revision 649710.. Thank Vadim for contributing.

        Show
        Alan Gates added a comment - Patch checked in at revision 649710.. Thank Vadim for contributing.
        Alan Gates made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Fix Version/s 0.1.0 [ 12312848 ]
        Alan Gates made changes -
        Assignee Vadim Geshel [ vgeshel ]
        Alan Gates made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        25s 1 Vadim Geshel 18/Apr/08 19:06
        Patch Available Patch Available Resolved Resolved
        4h 3m 1 Alan Gates 18/Apr/08 23:09
        Resolved Resolved Closed Closed
        704d 23h 51m 1 Alan Gates 24/Mar/10 22:01

          People

          • Assignee:
            Vadim Geshel
            Reporter:
            Vadim Geshel
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development