Pig
  1. Pig
  2. PIG-213

Non-static Log objects in org.apache.pig.data.* classes are inefficient

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.1.0
    • Fix Version/s: 0.1.0
    • Component/s: impl
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      LogFactory.getLog called from the constructor of Tuple accounts for significant percentage of my job's running time. The proposed fix is to make the Log fields static (which is generally standard practice).

      1. logging.patch
        3 kB
        Vadim Geshel

        Activity

        Hide
        Alan Gates added a comment -

        Patch checked in at revision 649710.. Thank Vadim for contributing.

        Show
        Alan Gates added a comment - Patch checked in at revision 649710.. Thank Vadim for contributing.
        Hide
        Mathieu Poumeyrol added a comment -

        Yes, I actualy had a similar patch ready. I measured a 2 figures percentage of time spent on the logger instantiation on some processes...

        Show
        Mathieu Poumeyrol added a comment - Yes, I actualy had a similar patch ready. I measured a 2 figures percentage of time spent on the logger instantiation on some processes...
        Hide
        Benjamin Reed added a comment -

        +1 Good catch.

        Show
        Benjamin Reed added a comment - +1 Good catch.

          People

          • Assignee:
            Vadim Geshel
            Reporter:
            Vadim Geshel
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development