Pig
  1. Pig
  2. PIG-2008

Cache outputFormat in HBaseStorage

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.9.0, 0.10.0
    • Component/s: build
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      getOutputFormat gets called more than one time in a StoreFunc. Modify HBaseStorage to only create an instance of TableOutputFormat one time (since it creates a new HTable connection each time) as opposed to multiple times like it does now.

      1. patch_file.txt
        1 kB
        Jacob Perkins

        Activity

        Hide
        Alan Gates added a comment -

        Dmitriy, could you take a look at this. It looks ok to me, but I'm not an HBase expert. I'll run the unit tests and such on it.

        Show
        Alan Gates added a comment - Dmitriy, could you take a look at this. It looks ok to me, but I'm not an HBase expert. I'll run the unit tests and such on it.
        Hide
        Dmitriy V. Ryaboy added a comment -

        Yeah looks good. Sorry I missed reviewing this earlier.

        Alan, objections to committing this to the 0.9 branch? The HTable connection leak is a bug.

        Show
        Dmitriy V. Ryaboy added a comment - Yeah looks good. Sorry I missed reviewing this earlier. Alan, objections to committing this to the 0.9 branch? The HTable connection leak is a bug.
        Hide
        Alan Gates added a comment -

        No objections. Unit tests pass. Running test-patch now.

        Show
        Alan Gates added a comment - No objections. Unit tests pass. Running test-patch now.
        Hide
        Alan Gates added a comment -

        Committed to trunk. Will commit to 0.9 branch shortly.

        Show
        Alan Gates added a comment - Committed to trunk. Will commit to 0.9 branch shortly.
        Hide
        Alan Gates added a comment -

        Patch checked into trunk and 0.9 branch. Thanks Jacob.

        Show
        Alan Gates added a comment - Patch checked into trunk and 0.9 branch. Thanks Jacob.

          People

          • Assignee:
            Jacob Perkins
            Reporter:
            Jacob Perkins
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 10m
              10m
              Remaining:
              Remaining Estimate - 10m
              10m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development