Pig
  1. Pig
  2. PIG-2005

Discrepancy in the way dry run handles semicolon in macro definition

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.0
    • Fix Version/s: 0.9.0
    • Component/s: grunt
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Macro definition requires a semicolon to mark the end. For example:

      define mymacro(x) returns y {... ...};
      

      But invoked through command line, the macro definitions without semicolon also work except in the case of dryrun. This discrepancy is due to GruntParser automatic appending a semicolon to Pig statements if semicolon is absent at the end. Dryrun GruntParser should do the same.

        Activity

        Hide
        Thejas M Nair added a comment -

        +1

        Show
        Thejas M Nair added a comment - +1
        Hide
        Richard Ding added a comment -

        Patch-test result:

             [exec] +1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
        

        Unit tests pass.

        Show
        Richard Ding added a comment - Patch-test result: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. Unit tests pass.
        Hide
        Richard Ding added a comment -

        Patch committed to trunk and 0.9 branch.

        Show
        Richard Ding added a comment - Patch committed to trunk and 0.9 branch.

          People

          • Assignee:
            Richard Ding
            Reporter:
            Richard Ding
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development