Uploaded image for project: 'Pig'
  1. Pig
  2. PIG-1946

HBaseStorage constructor syntax is error prone

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.10.0
    • None
    • None
    • More friendly HBaseStorage constructor syntax.

    Description

      Using HBaseStorage like so seems like a reasonable thing to do, but it will yield unexpected results:

      STORE result INTO 'hbase://foo' USING
       org.apache.pig.backend.hadoop.hbase.HBaseStorage(
       'info:first_name, info:last_name');
      

      The problem us that a column named info:first_name, will be created, with the trailing comma included. I've had numerous developers get tripped up on this issue since everywhere else in Pig variables are separated by commas, so I propose we fix it.

      I propose we trim leading/trailing commas from column names, but I'm open to other ideas.

      Also should we accept column names that are comman-delimited without spaces?

      Attachments

        1. PIG-1946_1.patch
          6 kB
          William W. Graham Jr
        2. PIG-1946_2.patch
          12 kB
          William W. Graham Jr
        3. PIG-1946_3.patch
          14 kB
          William W. Graham Jr

        Activity

          People

            billgraham William W. Graham Jr
            billgraham William W. Graham Jr
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: