Pig
  1. Pig
  2. PIG-966 Proposed rework for LoadFunc, StoreFunc, and Slice/r interfaces
  3. PIG-1250

Make StoreFunc an abstract class and create a mirror interface called StoreFuncInterface

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.7.0
    • Fix Version/s: 0.7.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    1. PIG-1250-2.patch
      39 kB
      Pradeep Kamath
    2. PIG-1250.patch
      33 kB
      Pradeep Kamath

      Activity

      Show
      Pradeep Kamath added a comment - The proposal is described in the following comments in PIG-966 : http://issues.apache.org/jira/browse/PIG-966?focusedCommentId=12836035&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12836035 http://issues.apache.org/jira/browse/PIG-966?focusedCommentId=12836080&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12836080
      Hide
      Pradeep Kamath added a comment -

      Patch which makes the change described in this issue. MapRedUtil.getStoreFunc() method is also removed in this patch since this method was applicable in the old API and is no longer applicable.

      Show
      Pradeep Kamath added a comment - Patch which makes the change described in this issue. MapRedUtil.getStoreFunc() method is also removed in this patch since this method was applicable in the old API and is no longer applicable.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12436618/PIG-1250.patch
      against trunk revision 912064.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 9 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      -1 javac. The applied patch generated 90 javac compiler warnings (more than the trunk's current 105 warnings).

      -1 findbugs. The patch appears to cause Findbugs to fail.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed core unit tests.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/213/testReport/
      Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/213/console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12436618/PIG-1250.patch against trunk revision 912064. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 90 javac compiler warnings (more than the trunk's current 105 warnings). -1 findbugs. The patch appears to cause Findbugs to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/213/testReport/ Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/213/console This message is automatically generated.
      Hide
      Pradeep Kamath added a comment -

      Had missed StoreFuncInterface.java in my previous patch - also fixed a javadoc warning.

      Show
      Pradeep Kamath added a comment - Had missed StoreFuncInterface.java in my previous patch - also fixed a javadoc warning.
      Hide
      Richard Ding added a comment -

      +1

      Show
      Richard Ding added a comment - +1
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12436630/PIG-1250-2.patch
      against trunk revision 912064.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 9 new or modified tests.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed core unit tests.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/214/testReport/
      Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/214/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/214/console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12436630/PIG-1250-2.patch against trunk revision 912064. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/214/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/214/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/214/console This message is automatically generated.
      Hide
      Pradeep Kamath added a comment -

      I ran all unit tests locally and they ran successfully - have committed the patch.

      Show
      Pradeep Kamath added a comment - I ran all unit tests locally and they ran successfully - have committed the patch.

        People

        • Assignee:
          Pradeep Kamath
          Reporter:
          Pradeep Kamath
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development