Pig
  1. Pig
  2. PIG-122

remove TokenMgrError and Co from svn properties in src/org/apache/pig/tools/pigscript/parser

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.1.0
    • Component/s: None
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      This is obsolete now and also will help people using the new build.xml to recognize they need to delete this files.
      Also we should add src-gen to the svn:ignore.

      1. PIG-122_v_1.patch
        0.3 kB
        Stefan Groschupf
      2. PIG-122-v02.patch
        0.2 kB
        Benjamin Francisoud
      3. PIG-122-v03.patch
        0.7 kB
        Benjamin Francisoud

        Activity

        Hide
        Alan Gates added a comment -

        The original generated .java files listed in this issue have already been moved to src-gen and so are no longer an issue. But I did check in the changes to the top level directory that added build and src-gen to the list of objects to be ignored. Thanks Stefan for the patch.

        Show
        Alan Gates added a comment - The original generated .java files listed in this issue have already been moved to src-gen and so are no longer an issue. But I did check in the changes to the top level directory that added build and src-gen to the list of objects to be ignored. Thanks Stefan for the patch.
        Hide
        Benjamin Francisoud added a comment -

        also removing useless svn:ignore from :

        • src/org/apache/pig/tools/pigscript/parser
        • src/org/apache/pig/impl/logicalLayer/parser
        Show
        Benjamin Francisoud added a comment - also removing useless svn:ignore from : src/org/apache/pig/tools/pigscript/parser src/org/apache/pig/impl/logicalLayer/parser
        Hide
        Stefan Groschupf added a comment -

        Right and remove the unused svn ignore in src/org/apache/pig/tools/pigscript/parser.

        Show
        Stefan Groschupf added a comment - Right and remove the unused svn ignore in src/org/apache/pig/tools/pigscript/parser.
        Hide
        Benjamin Francisoud added a comment -

        Files are generated in src-gen now, don't they ?
        I think we should svn:ignore "src-gen" and also the "build" folder

        Here's a patch to update svn:ignore prop in trunk

        Show
        Benjamin Francisoud added a comment - Files are generated in src-gen now, don't they ? I think we should svn:ignore "src-gen" and also the "build" folder Here's a patch to update svn:ignore prop in trunk
        Hide
        Stefan Groschupf added a comment -

        try
        svn propget svn:ignore src/org/apache/pig/tools/pigscript/parser within your pig folder on command line.
        it shows:
        TokenMgrError.java
        Token.java
        SimpleCharStream.java
        PigScriptParserTokenManager.java
        PigScriptParserConstants.java
        PigScriptParser.java
        ParseException.java

        What basically means that is file are ignored within any svn interaction. First, we simply should clean up this, since we not need this. Users that had used the old ant script. will run into the same duplicate class problem you did run into when using the new build.xml with out ant clean with the last one.

        Show
        Stefan Groschupf added a comment - try svn propget svn:ignore src/org/apache/pig/tools/pigscript/parser within your pig folder on command line. it shows: TokenMgrError.java Token.java SimpleCharStream.java PigScriptParserTokenManager.java PigScriptParserConstants.java PigScriptParser.java ParseException.java What basically means that is file are ignored within any svn interaction. First, we simply should clean up this, since we not need this. Users that had used the old ant script. will run into the same duplicate class problem you did run into when using the new build.xml with out ant clean with the last one.
        Hide
        Olga Natkovich added a comment -

        Since we reworked the build, all generated files are under src-gen which is not part of svn so I don't think we need to do anything. Am I missing something or can we close this bug?

        Show
        Olga Natkovich added a comment - Since we reworked the build, all generated files are under src-gen which is not part of svn so I don't think we need to do anything. Am I missing something or can we close this bug?

          People

          • Assignee:
            Benjamin Francisoud
            Reporter:
            Stefan Groschupf
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development