[PIG-106] Optimize Pig by replacing String '+' and StringBuffer with StringBuilder

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.1.0
• Fix Version/s: 0.1.0
• Component/s: impl
• Patch Info: Patch Available
• Assignee: Benjamin Francisoud
• Reporter: Benjamin Francisoud
• Created: 12/Feb/08 16:38
• Updated: 24/Mar/10 22:01
• Resolved: 17/Mar/08 19:34

Description

While investigating PIG-99, in TestBuiltin.java line 315:

for (int i = 0; i < LOOP_COUNT; i++) {
    for (int j = 0; j < LOOP_COUNT; j++) {
        sb.append(i + "\t" + i + "\t" + j % 2 + "\n");
    }
}

doing "i + "\t" + i + "\t" + j % 2 + "\n"" creates temporary String(s) reducing the advantages of using a StringBuffer.

Could be replace with:

for (int i = 0; i < LOOP_COUNT; i++) {
    for (int j = 0; j < LOOP_COUNT; j++) {
        sb.append(i);
        sb.append("\t");
        sb.append(i);
        sb.append("\t");
        sb.append(j % 2);
        sb.append("\n");
    }
}

Issue Links

• is related to: PIG-99 Tests: OutOfMemoryError: Java heap space