PhotArk
  1. PhotArk
  2. PHOTARK-22

Remove hardcoded "/photark" in js files

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: PhotArk M2
    • Fix Version/s: PhotArk M2
    • Component/s: PhotArk Admin Services
    • Labels:
      None
    • Environment:
      Ubuntu 9.10 64bit

      Description

      A url, "/photark/Gallery?smd" is used in some js files(admin.html, upload.html).

      It has a problem when the project is deployed to different context root.
      It would be changed.

        Activity

        Hide
        Luciano Resende added a comment -

        I believe this issue has been fixed with a solution based on the proposed patch. Please re-open if this is still an issue.

        Show
        Luciano Resende added a comment - I believe this issue has been fixed with a solution based on the proposed patch. Please re-open if this is still an issue.
        Hide
        Nick Choi added a comment -

        Here is my suggestion. In fact, I use this solution in my web-site.

        Firstly, I add photark.constants.GalleryServiceEndpoint into admin.html/upload.html and also include constants.js to avoid hardcoded.

        Next, I change constants.js.

        If someone deploys the project into another path, he would change only a variable in constants.js.

        Thanks.

        Show
        Nick Choi added a comment - Here is my suggestion. In fact, I use this solution in my web-site. Firstly, I add photark.constants.GalleryServiceEndpoint into admin.html/upload.html and also include constants.js to avoid hardcoded. Next, I change constants.js. If someone deploys the project into another path, he would change only a variable in constants.js. Thanks.

          People

          • Assignee:
            Unassigned
            Reporter:
            Nick Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development