Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-1508 VIEW enhancements
  3. PHOENIX-978

Allow views to extend base table's PK (only if last PK column is fixed length)

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0, 4.0.0
    • Fix Version/s: 4.5.0
    • Labels:

      Description

      CREATE VIEW syntax currently disallows PK constraint to be defined. As a result views and tenant-specific tables created using CREATE VIEW automatically inherit their base table's PK with no way to extend it.

      Base tables should be allowed to be created with a minimum of PK columns to support views, and views to extend PKs as desired. This would allow a single base table to support a heterogeneous set of views on top of it.

      1. PHOENIX-978.diff
        14 kB
        Eli Levine
      2. PHOENIX-978.patch
        32 kB
        Thomas D'Silva
      3. PHOENIX-978-v2.patch
        50 kB
        Thomas D'Silva
      4. PHOENIX-978.final.patch
        51 kB
        Thomas D'Silva

        Issue Links

          Activity

          Hide
          elilevine Eli Levine added a comment -
          Show
          elilevine Eli Levine added a comment - Somesh Sasalatti
          Hide
          jamestaylor James Taylor added a comment -

          With PHOENIX-1504 having been implemented and PHOENIX-2058 right behind it, this JIRA will need to tweak the validation logic on the server side that ensures that the column being added to the base table is compatible with any existing columns already in derived views.

          Show
          jamestaylor James Taylor added a comment - With PHOENIX-1504 having been implemented and PHOENIX-2058 right behind it, this JIRA will need to tweak the validation logic on the server side that ensures that the column being added to the base table is compatible with any existing columns already in derived views.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user elilevine opened a pull request:

          https://github.com/apache/phoenix/pull/91

          PHOENIX-978: allow views to extend parent's PK

          https://issues.apache.org/jira/browse/PHOENIX-978

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/elilevine/apache-phoenix PHOENIX-978

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/phoenix/pull/91.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #91


          commit 7e32f2566e56c1f7f5f0363806c7e3b81d37a9cb
          Author: Eli Levine <elilevine@apache.org>
          Date: 2015-06-26T18:36:06Z

          PHOENIX-978: Allow views to extend parent's PK in CREATE VIEW

          commit 0f33522ffbb0ddc09cd94bd02221a370c696276b
          Author: Eli Levine <elilevine@apache.org>
          Date: 2015-06-26T21:57:16Z

          PHOENIX-978: Allow views to extend parent's PK in ALTER VIEW + associated test fixes

          commit a9169f40f4c285757e91775de1b76850b832daa7
          Author: Eli Levine <elilevine@apache.org>
          Date: 2015-06-27T21:27:17Z

          PHOENIX-978: Make verification in ViewIT.testViewAddsNotNullPKColumn() more strict


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user elilevine opened a pull request: https://github.com/apache/phoenix/pull/91 PHOENIX-978 : allow views to extend parent's PK https://issues.apache.org/jira/browse/PHOENIX-978 You can merge this pull request into a Git repository by running: $ git pull https://github.com/elilevine/apache-phoenix PHOENIX-978 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/phoenix/pull/91.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #91 commit 7e32f2566e56c1f7f5f0363806c7e3b81d37a9cb Author: Eli Levine <elilevine@apache.org> Date: 2015-06-26T18:36:06Z PHOENIX-978 : Allow views to extend parent's PK in CREATE VIEW commit 0f33522ffbb0ddc09cd94bd02221a370c696276b Author: Eli Levine <elilevine@apache.org> Date: 2015-06-26T21:57:16Z PHOENIX-978 : Allow views to extend parent's PK in ALTER VIEW + associated test fixes commit a9169f40f4c285757e91775de1b76850b832daa7 Author: Eli Levine <elilevine@apache.org> Date: 2015-06-27T21:27:17Z PHOENIX-978 : Make verification in ViewIT.testViewAddsNotNullPKColumn() more strict
          Hide
          elilevine Eli Levine added a comment -

          James Taylor, mind taking a look at the pull request? At this point I have the code and associated tests to allow views to extend parent's PK.

          What is missing is the extra check that you mention above: during column creation on a parent table make sure no child views contain clashing columns. My take on the definition of such clashing is that we don't want to allow parents to create a column if (1) it's a PK column and a child view has extended its PK (meaning the view has a PK column in the same slot as the new parent column being added), or (2) it's a non-PK column and a child view has a column with the same name already. Anything else?

          Show
          elilevine Eli Levine added a comment - James Taylor , mind taking a look at the pull request? At this point I have the code and associated tests to allow views to extend parent's PK. What is missing is the extra check that you mention above: during column creation on a parent table make sure no child views contain clashing columns. My take on the definition of such clashing is that we don't want to allow parents to create a column if (1) it's a PK column and a child view has extended its PK (meaning the view has a PK column in the same slot as the new parent column being added), or (2) it's a non-PK column and a child view has a column with the same name already. Anything else?
          Hide
          jamestaylor James Taylor added a comment -

          For the extra check that's necessary, see PHOENIX-2058. We were trying to be less restrictive, as I think a common use case might be to add a column at the view first, and then realize later that you want that column to be added to the base table.

          Show
          jamestaylor James Taylor added a comment - For the extra check that's necessary, see PHOENIX-2058 . We were trying to be less restrictive, as I think a common use case might be to add a column at the view first, and then realize later that you want that column to be added to the base table.
          Hide
          jamestaylor James Taylor added a comment -

          +1 to the fix. Any thoughts on whether or not we should allow ALTER VIEW ADD <pk_column> PRIMARY KEY ?

          Show
          jamestaylor James Taylor added a comment - +1 to the fix. Any thoughts on whether or not we should allow ALTER VIEW ADD <pk_column> PRIMARY KEY ?
          Hide
          elilevine Eli Levine added a comment -

          Ah, thanks for pointing out PHOENIX-2058. I'll close out this jira without the extra check and we'll track that follow-up work in PHOENIX-2058, unless there are objections.

          Also, I already implemented support for ALTER VIEW ADD <pk_column> PRIMARY KEY. See this test in the pull request for example usage. Seems like if we support PKs for CREATE VIEW, we should do the same for ALTER VIEW.

          Show
          elilevine Eli Levine added a comment - Ah, thanks for pointing out PHOENIX-2058 . I'll close out this jira without the extra check and we'll track that follow-up work in PHOENIX-2058 , unless there are objections. Also, I already implemented support for ALTER VIEW ADD <pk_column> PRIMARY KEY. See this test in the pull request for example usage. Seems like if we support PKs for CREATE VIEW, we should do the same for ALTER VIEW.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Phoenix-master #803 (See https://builds.apache.org/job/Phoenix-master/803/)
          PHOENIX-978: allow views to extend parent's PK (elilevine: rev d6044944b7b1f4981a897c1c7626614659a972c7)

          • phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
          • phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
          • phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
          • phoenix-core/src/it/java/org/apache/phoenix/end2end/TenantSpecificTablesDDLIT.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Phoenix-master #803 (See https://builds.apache.org/job/Phoenix-master/803/ ) PHOENIX-978 : allow views to extend parent's PK (elilevine: rev d6044944b7b1f4981a897c1c7626614659a972c7) phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java phoenix-core/src/it/java/org/apache/phoenix/end2end/TenantSpecificTablesDDLIT.java
          Hide
          jamestaylor James Taylor added a comment -

          Is this fixed now, Eli Levine?

          Show
          jamestaylor James Taylor added a comment - Is this fixed now, Eli Levine ?
          Hide
          jamestaylor James Taylor added a comment -

          Eli Levine - there' an issue that Thomas D'Silva discovered with allowing a view to extend the base table's PK: https://issues.apache.org/jira/browse/PHOENIX-2058?focusedCommentId=14617813&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14617813

          It'll cause those rows to no longer be readable by the base table. This JIRA will require more work - basically we'd need to no longer assume that we can treat the remaining bytes in a row key as the value of the last column. This is an optimization we do to prevent walking the row key to look for our separator byte (for var length types only).

          Show
          jamestaylor James Taylor added a comment - Eli Levine - there' an issue that Thomas D'Silva discovered with allowing a view to extend the base table's PK: https://issues.apache.org/jira/browse/PHOENIX-2058?focusedCommentId=14617813&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14617813 It'll cause those rows to no longer be readable by the base table. This JIRA will require more work - basically we'd need to no longer assume that we can treat the remaining bytes in a row key as the value of the last column. This is an optimization we do to prevent walking the row key to look for our separator byte (for var length types only).
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user elilevine closed the pull request at:

          https://github.com/apache/phoenix/pull/91

          Show
          githubbot ASF GitHub Bot added a comment - Github user elilevine closed the pull request at: https://github.com/apache/phoenix/pull/91
          Hide
          elilevine Eli Levine added a comment -

          Thomas D'Silva, many thanks for finding the issue. James and I have chatted offline about it and decided to limit the scope of this Jira to allow views to extend parent's PK only if its last PK column is fixed length. I am working on this now and will submit a new pull request shortly.

          Show
          elilevine Eli Levine added a comment - Thomas D'Silva , many thanks for finding the issue. James and I have chatted offline about it and decided to limit the scope of this Jira to allow views to extend parent's PK only if its last PK column is fixed length. I am working on this now and will submit a new pull request shortly.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user elilevine opened a pull request:

          https://github.com/apache/phoenix/pull/97

          PHOENIX-978: Allow views to extend parent's PK only if parent's last …

          …PK column is fixed length

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/elilevine/apache-phoenix PHOENIX-978

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/phoenix/pull/97.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #97


          commit 70a1828acd951fc67aed7b66f30270237c615929
          Author: Eli Levine <elilevine@apache.org>
          Date: 2015-07-09T01:46:43Z

          PHOENIX-978: Allow views to extend parent's PK only if parent's last PK column is fixed length


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user elilevine opened a pull request: https://github.com/apache/phoenix/pull/97 PHOENIX-978 : Allow views to extend parent's PK only if parent's last … …PK column is fixed length You can merge this pull request into a Git repository by running: $ git pull https://github.com/elilevine/apache-phoenix PHOENIX-978 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/phoenix/pull/97.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #97 commit 70a1828acd951fc67aed7b66f30270237c615929 Author: Eli Levine <elilevine@apache.org> Date: 2015-07-09T01:46:43Z PHOENIX-978 : Allow views to extend parent's PK only if parent's last PK column is fixed length
          Hide
          elilevine Eli Levine added a comment -

          Working on fixing AlterTableIT now...

          Show
          elilevine Eli Levine added a comment - Working on fixing AlterTableIT now...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user elilevine commented on a diff in the pull request:

          https://github.com/apache/phoenix/pull/97#discussion_r34219051

          — Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java —
          @@ -2132,15 +2131,13 @@ public void testAddExistingViewColumnToBaseTableWithViews() throws Exception {
          }

          @Test

          • @Ignore
          • // enable this test after https://issues.apache.org/jira/browse/PHOENIX-978 is fixed
            public void testAddExistingViewPkColumnToBaseTableWithViews() throws Exception {
            Connection conn = DriverManager.getConnection(getUrl());
            try {
            conn.createStatement().execute("CREATE TABLE IF NOT EXISTS TABLEWITHVIEW ("
            + " ID char(10) NOT NULL,"
            + " COL1 integer NOT NULL,"
          • + " COL2 bigint NOT NULL,"
            + + " COL2 integer NOT NULL,"
              • End diff –

          Parent's last PK column must be fixed-length now.

          Show
          githubbot ASF GitHub Bot added a comment - Github user elilevine commented on a diff in the pull request: https://github.com/apache/phoenix/pull/97#discussion_r34219051 — Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java — @@ -2132,15 +2131,13 @@ public void testAddExistingViewColumnToBaseTableWithViews() throws Exception { } @Test @Ignore // enable this test after https://issues.apache.org/jira/browse/PHOENIX-978 is fixed public void testAddExistingViewPkColumnToBaseTableWithViews() throws Exception { Connection conn = DriverManager.getConnection(getUrl()); try { conn.createStatement().execute("CREATE TABLE IF NOT EXISTS TABLEWITHVIEW (" + " ID char(10) NOT NULL," + " COL1 integer NOT NULL," + " COL2 bigint NOT NULL," + + " COL2 integer NOT NULL," End diff – Parent's last PK column must be fixed-length now.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user elilevine commented on a diff in the pull request:

          https://github.com/apache/phoenix/pull/97#discussion_r34219079

          — Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java —
          @@ -2179,7 +2176,7 @@ public void testAddExistingViewPkColumnToBaseTableWithViews() throws Exception {
          assertEquals(rs.getString(1), "view1");
          assertEquals(rs.getInt(2), 12);
          assertEquals(rs.getInt(3), 13);

          • assertEquals(rs.getInt(4), 14);
            + assertEquals(rs.getBigDecimal(4).intValue(), 14);
              • End diff –

          Had to make this change, otherwise was getting BigDecimal rounding errors.

          Show
          githubbot ASF GitHub Bot added a comment - Github user elilevine commented on a diff in the pull request: https://github.com/apache/phoenix/pull/97#discussion_r34219079 — Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java — @@ -2179,7 +2176,7 @@ public void testAddExistingViewPkColumnToBaseTableWithViews() throws Exception { assertEquals(rs.getString(1), "view1"); assertEquals(rs.getInt(2), 12); assertEquals(rs.getInt(3), 13); assertEquals(rs.getInt(4), 14); + assertEquals(rs.getBigDecimal(4).intValue(), 14); End diff – Had to make this change, otherwise was getting BigDecimal rounding errors.
          Hide
          elilevine Eli Levine added a comment -

          Thomas D'Silva, can you take a look at the pull request now? I enabled the @Ignore'd test.

          Show
          elilevine Eli Levine added a comment - Thomas D'Silva , can you take a look at the pull request now? I enabled the @Ignore'd test.
          Hide
          jamestaylor James Taylor added a comment -

          Those aren't rounding errors, Eli Levine. The base table is reading VIEW_COL1 as the entire rest of the row key (which would include the value for VIEW_COL2 too). Instead, this ALTER TABLE should fail, because it's putting the metadata into an invalid state.

                      conn.createStatement().execute("ALTER TABLE TABLEWITHVIEW ADD VIEW_COL1 DECIMAL(10,2) PRIMARY KEY");
          

          Thomas D'Silva can help you with this or make the change for you. It's the code in MetaDataEndPointImpl.addRowsToChildViews() - if a view already has the base column being added and the column being added is variable length and the view has more columns after that, then it's an error. It's a great negative test.

          We should do the positive test too. If the base column being added is fixed length or the last PK column of the view, then you should be ok.

          Probably good to do an ALTER VIEW to add one of the columns to test that code path too.

          Show
          jamestaylor James Taylor added a comment - Those aren't rounding errors, Eli Levine . The base table is reading VIEW_COL1 as the entire rest of the row key (which would include the value for VIEW_COL2 too). Instead, this ALTER TABLE should fail, because it's putting the metadata into an invalid state. conn.createStatement().execute( "ALTER TABLE TABLEWITHVIEW ADD VIEW_COL1 DECIMAL(10,2) PRIMARY KEY" ); Thomas D'Silva can help you with this or make the change for you. It's the code in MetaDataEndPointImpl.addRowsToChildViews() - if a view already has the base column being added and the column being added is variable length and the view has more columns after that, then it's an error. It's a great negative test. We should do the positive test too. If the base column being added is fixed length or the last PK column of the view, then you should be ok. Probably good to do an ALTER VIEW to add one of the columns to test that code path too.
          Hide
          elilevine Eli Levine added a comment -

          Thanks for the comments, James Taylor. Thomas D'Silva and I chatted about this. What we agreed on is to disallow parent to extend its PK if it has any views. This is easy to explain to users and allows us not to worry about a multitude of edge cases that we would otherwise have to deal with. Thoughts?

          Show
          elilevine Eli Levine added a comment - Thanks for the comments, James Taylor . Thomas D'Silva and I chatted about this. What we agreed on is to disallow parent to extend its PK if it has any views. This is easy to explain to users and allows us not to worry about a multitude of edge cases that we would otherwise have to deal with. Thoughts?
          Hide
          jamestaylor James Taylor added a comment -

          Are there other edge cases than the one I mentioned with the check I indicated?

          Show
          jamestaylor James Taylor added a comment - Are there other edge cases than the one I mentioned with the check I indicated?
          Hide
          tdsilva Thomas D'Silva added a comment -

          After discussing this further we decided to allow adding pk columns to the base table for two cases:
          1. if all the view pk columns are exactly the same as the base table pk columns
          2. if we are adding all the existing view pk columns to the base table

          Show
          tdsilva Thomas D'Silva added a comment - After discussing this further we decided to allow adding pk columns to the base table for two cases: 1. if all the view pk columns are exactly the same as the base table pk columns 2. if we are adding all the existing view pk columns to the base table
          Hide
          tdsilva Thomas D'Silva added a comment -

          James Taylor I have attached a patch that combines Eli Levine changes and my changes for additional checks before adding a pk column to a base table that has views.

          Show
          tdsilva Thomas D'Silva added a comment - James Taylor I have attached a patch that combines Eli Levine changes and my changes for additional checks before adding a pk column to a base table that has views.
          Hide
          samarthjain Samarth Jain added a comment -

          Thomas D'Silva and I went through the code offline. Below were the changes we came up with:

          In MetadataClient, we probably don't need to check if the number of PK columns is < 1

          +    private boolean isLastPKVariableLength(PTable table) {
          +        List<PColumn> pkColumns = table.getPKColumns();
          +        if (pkColumns.size() < 1) {
          +            return false;
          +        } else {
          +            return !pkColumns.get(pkColumns.size()-1).getDataType().isFixedWidth();
          +        }
          +    }
          

          When adding a PK column to the base table, we should validate that the sort order of the pk column in the view is the same.

          The upgrade code currently checks column width/scale to see if the view has diverged from the base table. We should be consistent and do the same check while adding column to the base table. You would probably need to to tweak your tests to reflect the same.
          It would be great to have tests around the above two scenarios.

          There are a few other tests that can be added:
          1) Disallow creating a view with a custom PK if the base table's last PK column is variable length. The current test is doing this at the alter table add column. We should do the same for create view too.

          2) In testAddExistingViewPkColumnToBaseTableWithViews

          • Add tests that add new PK column to the base table that is variable width. Currently it is testing adding an existing column in the view.
          • For verifying values, it would be better to do a getString(column name).

          3) Tests for the scenario below:
          view1 (pkcol1, pkcol2), view2 (pkcol1, pkcol2)
          alter table basetable add pkcol1 primary key, pkcol2 primary key -> should work
          alter table basetable add pkcol2 primary key, pkcol1 primary key -> should fail

          Show
          samarthjain Samarth Jain added a comment - Thomas D'Silva and I went through the code offline. Below were the changes we came up with: In MetadataClient, we probably don't need to check if the number of PK columns is < 1 + private boolean isLastPKVariableLength(PTable table) { + List<PColumn> pkColumns = table.getPKColumns(); + if (pkColumns.size() < 1) { + return false ; + } else { + return !pkColumns.get(pkColumns.size()-1).getDataType().isFixedWidth(); + } + } When adding a PK column to the base table, we should validate that the sort order of the pk column in the view is the same. The upgrade code currently checks column width/scale to see if the view has diverged from the base table. We should be consistent and do the same check while adding column to the base table. You would probably need to to tweak your tests to reflect the same. It would be great to have tests around the above two scenarios. There are a few other tests that can be added: 1) Disallow creating a view with a custom PK if the base table's last PK column is variable length. The current test is doing this at the alter table add column. We should do the same for create view too. 2) In testAddExistingViewPkColumnToBaseTableWithViews Add tests that add new PK column to the base table that is variable width. Currently it is testing adding an existing column in the view. For verifying values, it would be better to do a getString(column name). 3) Tests for the scenario below: view1 (pkcol1, pkcol2), view2 (pkcol1, pkcol2) alter table basetable add pkcol1 primary key, pkcol2 primary key -> should work alter table basetable add pkcol2 primary key, pkcol1 primary key -> should fail
          Hide
          tdsilva Thomas D'Silva added a comment -

          Samarth Jain I have incorporated the review feedback.

          Show
          tdsilva Thomas D'Silva added a comment - Samarth Jain I have incorporated the review feedback.
          Hide
          jamestaylor James Taylor added a comment -

          One minor item: can you change all of the put.addColumn() calls to specify the timestamp instead of specifying it in the Put constructor? I've had issues doing the latter at times and found the former to be more reliable.

          Show
          jamestaylor James Taylor added a comment - One minor item: can you change all of the put.addColumn() calls to specify the timestamp instead of specifying it in the Put constructor? I've had issues doing the latter at times and found the former to be more reliable.
          Hide
          samarthjain Samarth Jain added a comment -

          Thanks for the updated patch Thomas D'Silva

          Patch looks good.

          It would be good to add a test that validates that creating a view with the PK different from the base table is not allowed if the PK of the base table is of variable length.

          Minor nit:

          I think you can use the Guava Objects.equal(@Nullable Object a, @Nullable Object b)

          +    private boolean isvalidAttribute(Object obj1, Object obj2) {
          +    	return (obj1!=null && obj1.equals(obj2)) || (obj1==null && obj2==null); 
              }
          
          Show
          samarthjain Samarth Jain added a comment - Thanks for the updated patch Thomas D'Silva Patch looks good. It would be good to add a test that validates that creating a view with the PK different from the base table is not allowed if the PK of the base table is of variable length. Minor nit: I think you can use the Guava Objects.equal(@Nullable Object a, @Nullable Object b) + private boolean isvalidAttribute( Object obj1, Object obj2) { + return (obj1!= null && obj1.equals(obj2)) || (obj1== null && obj2== null ); }
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Phoenix-master #833 (See https://builds.apache.org/job/Phoenix-master/833/)
          PHOENIX-978: Allow views to extend parent's PK only if parent's last PK column is fixed length (tdsilva: rev 66705d5170496bed7c39bd484517722ac8d09a13)

          • phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
          • phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java
          • phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
          • phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Phoenix-master #833 (See https://builds.apache.org/job/Phoenix-master/833/ ) PHOENIX-978 : Allow views to extend parent's PK only if parent's last PK column is fixed length (tdsilva: rev 66705d5170496bed7c39bd484517722ac8d09a13) phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user elilevine closed the pull request at:

          https://github.com/apache/phoenix/pull/97

          Show
          githubbot ASF GitHub Bot added a comment - Github user elilevine closed the pull request at: https://github.com/apache/phoenix/pull/97
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user elilevine commented on the pull request:

          https://github.com/apache/phoenix/pull/97#issuecomment-129690323

          Closing this PR. This has been checked in by @twdsilva.

          Show
          githubbot ASF GitHub Bot added a comment - Github user elilevine commented on the pull request: https://github.com/apache/phoenix/pull/97#issuecomment-129690323 Closing this PR. This has been checked in by @twdsilva.
          Hide
          enis Enis Soztutar added a comment -

          Bulk close of all issues that has been resolved in a released version.

          Show
          enis Enis Soztutar added a comment - Bulk close of all issues that has been resolved in a released version.

            People

            • Assignee:
              elilevine Eli Levine
              Reporter:
              elilevine Eli Levine
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development