Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-6519

Make SchemaTool work with lower case table and column names

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 4.17.0, 5.2.0, 4.16.2, 5.1.3
    • core
    • None

    Description

      I wrote this test as part of a PR for PHOENIX-6518 and it fails.

          @Test
          public void testCreateTableStatementLowerCase() throws Exception {
              String tableName = "lowecasetbl1";
              String schemaName = "lowecaseschemaname1";
              String pTableFullName = SchemaUtil.getEscapedTableName(schemaName, tableName);
              String createTableStmt = "CREATE TABLE "+ pTableFullName + "(\"smallK\" VARCHAR NOT NULL PRIMARY KEY, "
                      + "V1 VARCHAR, V2 VARCHAR) TTL=2592000, IMMUTABLE_ROWS=TRUE, DISABLE_WAL=TRUE";
              List<String> queries = new ArrayList<String>(){};
              queries.add(createTableStmt);
              String result = runSchemaExtractionTool("\"" + schemaName + "\"", "\"" + tableName + "\"", null, queries);
              Assert.assertEquals(createTableStmt, result.toUpperCase());
          }

      Expected:

      CREATE TABLE "lowecaseschemaname1"."lowecasetbl1"("smallK" VARCHAR NOT NULL PRIMARY KEY, V1 VARCHAR, V2 VARCHAR) TTL=2592000, IMMUTABLE_ROWS=TRUE, DISABLE_WAL=TRUE

      Actual result:

      CREATE TABLE LOWECASESCHEMANAME1.LOWECASETBL1(SMALLK VARCHAR NOT NULL PRIMARY KEY, V1 VARCHAR, V2 VARCHAR) TTL=2592000, IMMUTABLE_ROWS=TRUE, DISABLE_WAL=TRUE

      Attachments

        Issue Links

          Activity

            People

              richardantal Richárd Antal
              richardantal Richárd Antal
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: