[PHOENIX-6450] Checkstyle creating warnings for line length > 80 but < 100

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.17.0, 5.2.0, 4.16.2, 5.1.3
• Component/s: core
• Assignee: Richárd Antal
• Reporter: Rushabh Shah
• Created: 20/Apr/21 15:32
• Updated: 29/Jul/21 15:47
• Resolved: 29/Jul/21 13:31

Description

Sample build: https://github.com/apache/phoenix/pull/1200

Checkstyle warnings for 

./phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java:375:      // Need to add cell tags to Delete Marker before we do any index processing: Line is longer than 80 characters (found 81). [LineLength]
./phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java:949:    public static void setDeleteAttributes(MiniBatchOperationInProgress<Mutation> miniBatchOp): Line is longer than 80 characters (found 94). [LineLength]
./phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java:957:            byte[] sourceOpAttr = m.getAttribute(QueryServices.SOURCE_OPERATION_ATTRIB);: Line is longer than 80 characters (found 88). [LineLength]
./phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java:961:            Tag sourceOpTag = new Tag(PhoenixTagType.SOURCE_OPERATION_TAG_TYPE, sourceOpAttr);: Line is longer than 80 characters (found 94). [LineLength]
./phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java:963:            for (CellScanner cellScanner = m.cellScanner(); cellScanner.advance();) {: Line is longer than 80 characters (found 85). [LineLength]

Checkstyle check is creating warnings for line length which are greater than 80.
I see we have couple of config parameters specifying max line length which is 100.
https://github.com/apache/phoenix/blob/4.x/src/main/config/checkstyle/checker.xml#L223-L224
https://github.com/apache/phoenix/blob/4.x/dev/test-patch.properties#L25

I don't understand where this 80 value comes from ?

stoty vjasani yanxinyi Any ideas ?

Issue Links

• links to: GitHub Pull Request #1276