[PHOENIX-6407] phoenixdb for Python silently ignores placeholders < placeholder arguments

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.1.0
• Fix Version/s: queryserver-6.0.0, python-phoenixdb-1.1.0
• Component/s: python
• Labels: phoenixdb
• Assignee: Richárd Antal
• Reporter: Ben DeMott
• Created: 09/Mar/21 17:43
• Updated: 19/Aug/21 18:16
• Resolved: 08/Jul/21 11:52

Description

The `phoenixdb` driver for Python does not alert the user to excess arguments that are not represented by placeholders.

Example 1, fewer arguments than placeholders raise exception (works as expected)

 

cursor.execute("UPSERT INTO users VALUES (?, ?, ?)", (123, 'John Doe')) 

phoenixdb.errors.ProgrammingError: ('Number of columns upserting must match number of values. Numbers of columns: 3. Number of values: 4 tableName=USERS', 1020, '42Y60', None)

Example 2, additional arguments than placeholders is silently ignored

cursor.execute("UPSERT INTO users VALUES (?, ?)", (123, 'John Doe', 'admin'))

The program should generate a similar error to the one above, that the columns need to match the replacements.

 

 

Issue Links

• links to: GitHub Pull Request #71