Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-6282

Generate PB files inline with build and remove checked in files

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1.0, 4.16.0
    • Component/s: None
    • Labels:
      None
    • Release Note:
      Hide
      We no longer have generated protobuf Java files available in source code. These files are expected to be generated inline with mvn build. We have also used an optimization with the plugin to ensure protoc is not invoked with mvn build if no .proto file is updated between two consecutive builds.
      Show
      We no longer have generated protobuf Java files available in source code. These files are expected to be generated inline with mvn build. We have also used an optimization with the plugin to ensure protoc is not invoked with mvn build if no .proto file is updated between two consecutive builds.

      Description

      We can use a new PB maven plugin to generate PB files with build rather than checking in generated PB files (~2 MB as of now) in source code. The plugin also provides an optimization for protoc invocation. With checkStaleness property, protoc will not be invoked if no .proto file is changed. Only separate build will invoke protoc and generate PB files inline.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                vjasani Viraj Jasani
                Reporter:
                vjasani Viraj Jasani
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: