[PHOENIX-5958] Diverged view created via an older client still sees dropped column data

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 5.0.0, 4.15.0
• Fix Version/s: 5.1.0, 4.16.0
• Assignee: Chinmay Kulkarni
• Reporter: Chinmay Kulkarni
• Created: 15/Jun/20 23:43
• Updated: 18/Nov/20 20:12
• Resolved: 03/Aug/20 19:25

Description

By "diverged view" I mean creating a view and then dropping one of the inherited columns from the view. Steps to reproduce:

Start a 4.x server and connect with a pre-4.15 (I tried a 4.14.3) client

CREATE TABLE IF NOT EXISTS S.T (A INTEGER PRIMARY KEY, B INTEGER);
CREATE VIEW IF NOT EXISTS S.V (new_col INTEGER) AS SELECT * FROM S.T;
UPSERT INTO S.T VALUES(1,2);
ALTER VIEW S.V DROP COLUMN B;
SELECT * FROM S.T; 
+----+------+
| A  |  B   |
+----+------+
| 1  |  2   |
+----+------+

SELECT * FROM S.V; gives:
+----+------+----------+
| B  |  A   |  NEW_COL |
+----+------+----------+
| 2  |  1   |  null    |
+----+------+----------+

Though the column 'B' has been dropped from the view. This is a problem for both when phoenix.allow.system.catalog.rollback=true or false. This exact bug does not happen for a 4.x client, though PHOENIX-6030 and PHOENIX-6032 highlight other issues related to this code path for 4.x clients.
The problem is mostly due to changes introduced by PHOENIX-4893

Issue Links

• links to: GitHub Pull Request #849