[PHOENIX-5641] Decouple phoenix-queryserver from phoenix-core

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.1.0, 4.16.0
• Fix Version/s: 5.1.0, 4.16.0
• Assignee: Istvan Toth
• Reporter: Istvan Toth
• Created: 19/Dec/19 07:13
• Updated: 07/May/20 05:53
• Resolved: 05/Mar/20 08:23

Description

phoenix-queryserver has been moved to a separate repo, and it's versioning has been decoupled from that of phoenix-core.

Yet, phoenix-queryserver still uses code from phoenix-core, and phoenix-core in turn contains code that is only used by phoenix-queryserver.

This causes (at least) the following problems:

• Adding new features to PQS is problematic, because it depends on an old released version of phoenix
• The phoenix-thin-client includes phoenix code, that is not really necessary

I propose fully decoupling the PQS code from phoenix proper. This effectively means:

• duplicating the PQS specific configuration parameter names and defaults in PQS
• copying a minimal amount of code for building the JDBC connection URL
• copying the InstanceResolver cache class

The tests are still dependent on phoenix-core, but I do not consider that a problem.

If/when this patch lands in PQS, we should also remove the PQS specific parameters from phoenix-core.

Issue Links

• relates to: PHOENIX-5758 Apply cleanups to 4.x branch
• relates to: PHOENIX-5256 Remove queryserver related scripts/files as the former has its own repo
• links to: GitHub Pull Request #13
• links to: GitHub Pull Request #663