[PHOENIX-5176] KeyRange.compareUpperRange(KeyRang 1, KeyRang 2) returns wrong result when two key ranges have the same upper bound values but one is inclusive and another is exclusive

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 4.15.0, 5.1.0
• Assignee: Bin Shi
• Reporter: Bin Shi
• Created: 05/Mar/19 22:10
• Updated: 21/Dec/19 00:53
• Resolved: 27/Jun/19 16:44

Description

In KeyRange.java, 
    public static int compareUpperRange(KeyRange rowKeyRange1, KeyRange rowKeyRange2) {
        int result = Boolean.compare(rowKeyRange1.upperUnbound(), rowKeyRange2.upperUnbound());
        if (result != 0) {
            return result;
        }
        result = Bytes.BYTES_COMPARATOR.compare(rowKeyRange1.getUpperRange(), rowKeyRange2.getUpperRange());
        if (result != 0) {
            return result;
        }
        return Boolean.compare(rowKeyRange2.isUpperInclusive(), rowKeyRange1.isUpperInclusive());
    }
 
The last line in yellow color should be "return Boolean.compare(rowKeyRange1.isUpperInclusive(), rowKeyRange2.isUpperInclusive());".  Given rowKeyRange1 [3, 5) and rowKeyRange2 [3, 5], the function should return -1, but now it returns 1 due to the bug I mentioned.
 
The KeyRange.compareUpperRange is only used in KeyRange.intersect(List<KeyRange> rowKeyRanges1, List<KeyRange> rowKeyRanges2). Given rowKeyRanges1 {[3, 5), [5, 6)} and rowKeyRanges2{[3, 5], [6, 7]}, the function should return {[3, 5), [5, 5]}, i.e., {[3, 5]}, but it seems that now it returns {[3,5)} due to the bug.

Issue Links

• links to: GitHub Pull Request #471