Description
Currently we are logging key value when the new aggregate row found for scan ordered queries which is info log. This is going to add lot of overhead to the queries because sometimes we may write almost all the rows into log.
results.add(keyValue); if (logger.isInfoEnabled()) { logger.info(LogUtil.addCustomAnnotations("Adding new aggregate row: " + keyValue + ",for current key " + Bytes.toStringBinary(currentKey.get(), currentKey.getOffset(), currentKey.getLength()) + ", aggregated values: " + Arrays.asList(rowAggregators), ScanUtil.getCustomAnnotations(scan))); }
[root@ctr-e138-1518143905142-358323-01-000010 hbase]# grep "Adding new aggregate row: " hbase-hbase-regionserver-ctr-e138-1518143905142-358323-01-000010.log.* | wc -l 19082854
It's changed recently as part of PHOENIX-4742 so better to make it debug only.
- if (logger.isDebugEnabled()) { - logger.debug(LogUtil.addCustomAnnotations("Adding new aggregate row: " + if (logger.isInfoEnabled()) { + logger.info(LogUtil.addCustomAnnotations("Adding new aggregate row: "