Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-4786

Reduce log level to debug when logging new aggregate row key found and added results for scan ordered queries

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0.0, 4.14.1
    • Labels:
      None

      Description

      Currently we are logging key value when the new aggregate row found for scan ordered queries which is info log. This is going to add lot of overhead to the queries because sometimes we may write almost all the rows into log.

                          results.add(keyValue);
                          if (logger.isInfoEnabled()) {
                              logger.info(LogUtil.addCustomAnnotations("Adding new aggregate row: "
                                      + keyValue
                                      + ",for current key "
                                      + Bytes.toStringBinary(currentKey.get(), currentKey.getOffset(),
                                          currentKey.getLength()) + ", aggregated values: "
                                      + Arrays.asList(rowAggregators), ScanUtil.getCustomAnnotations(scan)));
                          }
      
      [root@ctr-e138-1518143905142-358323-01-000010 hbase]# grep "Adding new aggregate row: " hbase-hbase-regionserver-ctr-e138-1518143905142-358323-01-000010.log.* | wc -l
      19082854
      

      It's changed recently as part of PHOENIX-4742 so better to make it debug only.

      -                    if (logger.isDebugEnabled()) {
      -                        logger.debug(LogUtil.addCustomAnnotations("Adding new aggregate row: "
      +                    if (logger.isInfoEnabled()) {
      +                        logger.info(LogUtil.addCustomAnnotations("Adding new aggregate row: "
      

        Attachments

        1. PHOENIX-4786_v2.patch
          1 kB
          Rajeshbabu Chintaguntla
        2. PHOENIX-4786.patch
          1 kB
          Rajeshbabu Chintaguntla

          Activity

            People

            • Assignee:
              rajeshbabu Rajeshbabu Chintaguntla
              Reporter:
              rajeshbabu Rajeshbabu Chintaguntla
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: