[PHOENIX-4514] A incorrect key object is used in SequenceManager#validateSequences

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 5.0.0-alpha, 4.14.0, 4.13.2-cdh
• Assignee: Chia-Ping Tsai
• Reporter: Chia-Ping Tsai
• Created: 03/Jan/18 10:21
• Updated: 26/Jul/18 01:14
• Resolved: 11/Jan/18 23:30

Description

nextSequences.get( i ) -> nextSequences.get( i ).getSequenceKey()

SequenceManager.java

        for (int i = 0; i < nextSequences.size(); i++) {
            sequencePosition[i] = sequenceMap.get(nextSequences.get(i)).getIndex();
        }

It won't cause bug since the impl of SequenceAllocation#hashCode is equal with SequenceKey#hashCode. However, it still a potential bug so a fix is necessary I believe.

SequenceAllocation.java

    @Override
    public int hashCode() {
        return sequenceKey.hashCode();
    }