Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-4207

Improve zombie detection in test-patch.sh

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.12.0
    • Labels:
      None

      Description

      In watching INFRA-15074, I was reminded about the zombie-test checking that test-patch.sh does is a bit aggressive.

      Should be able to exclude non-Phoenix surefire instances from our process listing.

        Activity

        Hide
        elserj Josh Elser added a comment -

        .001 Did a trivial check locally to make sure this new one-liner worked as expected.

        Show
        elserj Josh Elser added a comment - .001 Did a trivial check locally to make sure this new one-liner worked as expected.
        Hide
        jamestaylor James Taylor added a comment -

        +1. Thanks, Josh Elser!

        Show
        jamestaylor James Taylor added a comment - +1. Thanks, Josh Elser !
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12886964/PHOENIX-4207.001.patch
        against master branch at commit 1407a5ec84ff8ceb50e25efe6085d62df4544228.
        ATTACHMENT ID: 12886964

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1435//testReport/
        Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1435//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12886964/PHOENIX-4207.001.patch against master branch at commit 1407a5ec84ff8ceb50e25efe6085d62df4544228. ATTACHMENT ID: 12886964 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1435//testReport/ Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1435//console This message is automatically generated.
        Hide
        elserj Josh Elser added a comment -

        Thanks for the quick review, James! Pushed.

        Show
        elserj Josh Elser added a comment - Thanks for the quick review, James! Pushed.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build Phoenix-master #1798 (See https://builds.apache.org/job/Phoenix-master/1798/)
        PHOENIX-4207 Improve zombie-test detection in test-patch.sh (elserj: rev 0311e4f56fa10a6ea3eb3e0dce8a9d6fa70a48f8)

        • (edit) dev/test-patch.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Phoenix-master #1798 (See https://builds.apache.org/job/Phoenix-master/1798/ ) PHOENIX-4207 Improve zombie-test detection in test-patch.sh (elserj: rev 0311e4f56fa10a6ea3eb3e0dce8a9d6fa70a48f8) (edit) dev/test-patch.sh

          People

          • Assignee:
            elserj Josh Elser
            Reporter:
            elserj Josh Elser
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development