Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-4202

Clear client side cache in ConnectionQueryServicesImpl#clearCache()

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.12.0
    • Labels:
      None

      Activity

      Hide
      samarthjain Samarth Jain added a comment -

      James Taylor, please review.

      Show
      samarthjain Samarth Jain added a comment - James Taylor , please review.
      Hide
      jamestaylor James Taylor added a comment -

      +1, but might be worth a precommit run to make sure there's no unexpected results.

      Show
      jamestaylor James Taylor added a comment - +1, but might be worth a precommit run to make sure there's no unexpected results.
      Hide
      hadoopqa Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12886746/PHOENIX-4202.patch
      against master branch at commit 1407a5ec84ff8ceb50e25efe6085d62df4544228.
      ATTACHMENT ID: 12886746

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 lineLengths. The patch does not introduce lines longer than 100

      +1 core tests. The patch passed unit tests in .

      -1 core zombie tests. There are 5 zombie test(s): at org.apache.hadoop.hbase.master.balancer.BalancerTestBase.testWithCluster(BalancerTestBase.java:525)
      at org.apache.hadoop.hbase.master.balancer.BalancerTestBase.testWithCluster(BalancerTestBase.java:515)
      at org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2.testRegionReplicasOnLargeCluster(TestStochasticLoadBalancer2.java:67)
      at org.apache.hadoop.hbase.master.balancer.BalancerTestBase.testWithCluster(BalancerTestBase.java:514)
      at org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer.testMidCluster2(TestStochasticLoadBalancer.java:566)
      at org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache.testSnapshotTempDirReload(TestSnapshotFileCache.java:122)
      at org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport.testTableCreation(TestFavoredNodeTableImport.java:95)
      at org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions.testSystemTablesOnMaster(TestRegionsOnMasterOptions.java:144)

      Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1434//testReport/
      Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1434//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12886746/PHOENIX-4202.patch against master branch at commit 1407a5ec84ff8ceb50e25efe6085d62df4544228. ATTACHMENT ID: 12886746 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 core tests . The patch passed unit tests in . -1 core zombie tests . There are 5 zombie test(s): at org.apache.hadoop.hbase.master.balancer.BalancerTestBase.testWithCluster(BalancerTestBase.java:525) at org.apache.hadoop.hbase.master.balancer.BalancerTestBase.testWithCluster(BalancerTestBase.java:515) at org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2.testRegionReplicasOnLargeCluster(TestStochasticLoadBalancer2.java:67) at org.apache.hadoop.hbase.master.balancer.BalancerTestBase.testWithCluster(BalancerTestBase.java:514) at org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer.testMidCluster2(TestStochasticLoadBalancer.java:566) at org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache.testSnapshotTempDirReload(TestSnapshotFileCache.java:122) at org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport.testTableCreation(TestFavoredNodeTableImport.java:95) at org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions.testSystemTablesOnMaster(TestRegionsOnMasterOptions.java:144) Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1434//testReport/ Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1434//console This message is automatically generated.
      Hide
      samarthjain Samarth Jain added a comment -

      QA test run looks good. Will commit.

      Show
      samarthjain Samarth Jain added a comment - QA test run looks good. Will commit.
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Jenkins build Phoenix-master #1796 (See https://builds.apache.org/job/Phoenix-master/1796/)
      PHOENIX-4202 Clear client side cache in (samarth: rev 41e137199a9e42c080475c96653be6e9fc451b99)

      • (edit) phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Phoenix-master #1796 (See https://builds.apache.org/job/Phoenix-master/1796/ ) PHOENIX-4202 Clear client side cache in (samarth: rev 41e137199a9e42c080475c96653be6e9fc451b99) (edit) phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java

        People

        • Assignee:
          samarthjain Samarth Jain
          Reporter:
          samarthjain Samarth Jain
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development