Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-4445 Modify all ITs to not use CurrentSCN or CURRENT_SCN
  3. PHOENIX-4180

Modify tests to generate unique table names and not use CURRENT_SCN

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 4.12.0
    • 4.12.0
    • None
    • None

    Description

      Here is update provided by jamestaylor

      • switch from using hard coded table names to generated table names (using the BaseTest.generateUniqueName() function).
      • remove the setting of the CURRENT_SCN property name
      • verify the tests still passes

      Here's an example commit of the conversion of one of them: https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commitdiff;h=814276d4b4b08be0681f1c402cfb3cc35f01fa0a;hp=b46cbd375e3d2ee9a11644825c13937572c027cd

      Here's the list of tests that need to be converted:

      ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayIT.java
      ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ClientTimeArithmeticQueryIT.java
      ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ColumnProjectionOptimizationIT.java
      ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ConcurrentMutationsIT.java
      ./phoenix-core/src/it/java/org/apache/phoenix/end2end/CursorWithRowValueConstructorIT.java

      Attachments

        1. PHOENIX-4180.patch
          204 kB
          James R. Taylor

        Activity

          People

            rahulshrivastava Rahul Shrivastava
            rahulshrivastava Rahul Shrivastava
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: