Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-4180

Modify tests to generate unique table names and not use CURRENT_SCN

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.12.0
    • Fix Version/s: 4.12.0
    • Labels:
      None

      Description

      Here is update provided by James Taylor

      • switch from using hard coded table names to generated table names (using the BaseTest.generateUniqueName() function).
      • remove the setting of the CURRENT_SCN property name
      • verify the tests still passes

      Here's an example commit of the conversion of one of them: https://git-wip-us.apache.org/repos/asf?p=phoenix.git;a=commitdiff;h=814276d4b4b08be0681f1c402cfb3cc35f01fa0a;hp=b46cbd375e3d2ee9a11644825c13937572c027cd

      Here's the list of tests that need to be converted:

      ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayIT.java
      ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ClientTimeArithmeticQueryIT.java
      ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ColumnProjectionOptimizationIT.java
      ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ConcurrentMutationsIT.java
      ./phoenix-core/src/it/java/org/apache/phoenix/end2end/CursorWithRowValueConstructorIT.java

      1. PHOENIX-4180.patch
        204 kB
        James Taylor

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user rhshriva opened a pull request:

          https://github.com/apache/phoenix/pull/271

          PHOENIX-4180 - Modify tests to generate unique table names and not us…

          The following tests was changed.

          ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayIT.java
          ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ClientTimeArithmeticQueryIT.java
          ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ColumnProjectionOptimizationIT.java
          ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ConcurrentMutationsIT.java
          ./phoenix-core/src/it/java/org/apache/phoenix/end2end/CursorWithRowValueConstructorIT.java

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/rhshriva/phoenix master_IT_fix

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/phoenix/pull/271.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #271


          commit 17c278a130ca2b0b3fe82abe4dda9cfe61c4fa08
          Author: Rahul <rshrivastava@salesforce.com>
          Date: 2017-09-13T19:34:10Z

          PHOENIX-4180 - Modify tests to generate unique table names and not use CURRENT_SCN


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user rhshriva opened a pull request: https://github.com/apache/phoenix/pull/271 PHOENIX-4180 - Modify tests to generate unique table names and not us… The following tests was changed. ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayIT.java ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ClientTimeArithmeticQueryIT.java ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ColumnProjectionOptimizationIT.java ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ConcurrentMutationsIT.java ./phoenix-core/src/it/java/org/apache/phoenix/end2end/CursorWithRowValueConstructorIT.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/rhshriva/phoenix master_IT_fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/phoenix/pull/271.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #271 commit 17c278a130ca2b0b3fe82abe4dda9cfe61c4fa08 Author: Rahul <rshrivastava@salesforce.com> Date: 2017-09-13T19:34:10Z PHOENIX-4180 - Modify tests to generate unique table names and not use CURRENT_SCN
          Hide
          rahulshrivastava Rahul Shrivastava added a comment -

          James Taylor

          Patch is https://github.com/apache/phoenix/pull/271 for only 5 out of the 10 tests. The tests remaining are

          ./phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java
          ./phoenix-core/src/it/java/org/apache/phoenix/end2end/DistinctCountIT.java
          ./phoenix-core/src/it/java/org/apache/phoenix/end2end/DropSchemaIT.java
          ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ExtendedQueryExecIT.java
          ./phoenix-core/src/it/java/org/apache/phoenix/end2end/FunkyNamesIT.java

          Show
          rahulshrivastava Rahul Shrivastava added a comment - James Taylor Patch is https://github.com/apache/phoenix/pull/271 for only 5 out of the 10 tests. The tests remaining are ./phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java ./phoenix-core/src/it/java/org/apache/phoenix/end2end/DistinctCountIT.java ./phoenix-core/src/it/java/org/apache/phoenix/end2end/DropSchemaIT.java ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ExtendedQueryExecIT.java ./phoenix-core/src/it/java/org/apache/phoenix/end2end/FunkyNamesIT.java
          Hide
          jamestaylor James Taylor added a comment -

          Thanks for the patch, Rahul Shrivastava. I had to make a few more changes, but what you had got us most of the way there. FYI, here's the final patch.

          Show
          jamestaylor James Taylor added a comment - Thanks for the patch, Rahul Shrivastava . I had to make a few more changes, but what you had got us most of the way there. FYI, here's the final patch.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Phoenix-master #1796 (See https://builds.apache.org/job/Phoenix-master/1796/)
          PHOENIX-4180 Modify tests to generate unique table names and not use (jtaylor: rev 26a7b9e8b051c270ae8003332ed2ebb4bb91d972)

          • (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ColumnProjectionOptimizationIT.java
          • (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ConcurrentMutationsIT.java
          • (delete) phoenix-core/src/it/java/org/apache/phoenix/end2end/OutOfOrderMutationsIT.java
          • (edit) phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
          • (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/CursorWithRowValueConstructorIT.java
          • (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ClientTimeArithmeticQueryIT.java
          • (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayIT.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Phoenix-master #1796 (See https://builds.apache.org/job/Phoenix-master/1796/ ) PHOENIX-4180 Modify tests to generate unique table names and not use (jtaylor: rev 26a7b9e8b051c270ae8003332ed2ebb4bb91d972) (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ColumnProjectionOptimizationIT.java (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ConcurrentMutationsIT.java (delete) phoenix-core/src/it/java/org/apache/phoenix/end2end/OutOfOrderMutationsIT.java (edit) phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/CursorWithRowValueConstructorIT.java (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ClientTimeArithmeticQueryIT.java (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ArrayIT.java

            People

            • Assignee:
              rahulshrivastava Rahul Shrivastava
              Reporter:
              rahulshrivastava Rahul Shrivastava
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development