[PHOENIX-4053] Lock row exclusively when necessary for mutable secondary indexing

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.12.0
• Labels: secondary_index
• Assignee: James R. Taylor
• Reporter: James R. Taylor
• Created: 28/Jul/17 20:41
• Updated: 11/Oct/17 22:36
• Resolved: 31/Jul/17 18:19

Description

From HBase 1.2 on, rows are not exclusively locked when the preBatchMutate call is made (see HBASE-18474). The mutable secondary index (global and local) depend on this to get a consistent snapshot of a row between the point when the current row value is looked up, and when the new row is written, until the mvcc is advanced. Otherwise, a subsequent update to a row may not see the current row state. Even with pre HBase 1.2 releases, the lock isn't held long enough for us. We need to hold the locks from the start of the preBatchMutate (when we read the data table to get the prior row values) until the mvcc is advanced (beginning of postBatchMutateIndispensably).

Given the above, it's best if Phoenix manages the row locking itself (mimicing the current HBase mechanism).

Issue Links

• relates to: HBASE-18474 Document how HRegion#doMiniBatchMutation is acquiring read row locks
• relates to: HBASE-18127 Enable state to be passed between the region observer coprocessor hook calls
• relates to: HBASE-18482 Enable state to be passed between the batch mutate coprocessors