[PHOENIX-4004] Assorted improvements to reduce garbage in mutable index codepath

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.12.0
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 07/Jul/17 20:26
• Updated: 26/Jul/17 05:28
• Resolved: 21/Jul/17 21:52

Description

During some $dayjob testing, I found a couple of places where we were unnecessarily creating garbage in the RS. When "forward-porting" this change, most of the areas were already cleaned up but there are a few that still apply.

• ArrayList initial sizing
• Avoid indirection of the (single-threaded) ExecutorService in IndexBuildManager (just pure overhead)
• Some unnecessary KeyValue copies and an array copy (an avoidance of deprecated HBase API)
• Avoid extra System.arraycopy calls in CoveredColumnIndexCodec via the ArrayUtils.addAll call