Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-3806

Reduce IndexUpdateManager sorting overhead during Index rebuild

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.10.0
    • Fix Version/s: 4.11.0
    • Component/s: None
    • Labels:

      Description

      Here's the stack trace. The Array contains 50001 Delete Mutations in this case.
      It seems the code is sorting this over and over again.

      Thread 170 (B.DefaultRpcServer.handler=67,queue=7,port=60020):
        State: RUNNABLE
        Blocked count: 220598
        Waited count: 377933
        Stack:
          java.util.TimSort.binarySort(TimSort.java:296)
          java.util.TimSort.sort(TimSort.java:239)
          java.util.Arrays.sort(Arrays.java:1438)
          org.apache.phoenix.hbase.index.covered.update.SortedCollection.iterator(SortedCollection.java:78)
          org.apache.phoenix.hbase.index.covered.update.IndexUpdateManager.fixUpCurrentUpdates(IndexUpdateManager.java:128)
          org.apache.phoenix.hbase.index.covered.update.IndexUpdateManager.addIndexUpdate(IndexUpdateManager.java:115)
          org.apache.phoenix.hbase.index.covered.NonTxIndexBuilder.addCurrentStateMutationsForBatch(NonTxIndexBuilder.java:333)
          org.apache.phoenix.hbase.index.covered.NonTxIndexBuilder.addUpdateForGivenTimestamp(NonTxIndexBuilder.java:258)
          org.apache.phoenix.hbase.index.covered.NonTxIndexBuilder.addMutationsForBatch(NonTxIndexBuilder.java:231)
          org.apache.phoenix.hbase.index.covered.NonTxIndexBuilder.batchMutationAndAddUpdates(NonTxIndexBuilder.java:109)
          org.apache.phoenix.hbase.index.covered.NonTxIndexBuilder.getIndexUpdate(NonTxIndexBuilder.java:71)
          org.apache.phoenix.hbase.index.builder.IndexBuildManager$1.call(IndexBuildManager.java:137)
          org.apache.phoenix.hbase.index.builder.IndexBuildManager$1.call(IndexBuildManager.java:133)
          java.util.concurrent.FutureTask.run(FutureTask.java:266)
          com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:293)
          com.google.common.util.concurrent.AbstractListeningExecutorService.submit(AbstractListeningExecutorService.java:61)
          org.apache.phoenix.hbase.index.parallel.BaseTaskRunner.submit(BaseTaskRunner.java:58)
          org.apache.phoenix.hbase.index.parallel.BaseTaskRunner.submitUninterruptible(BaseTaskRunner.java:99)
          org.apache.phoenix.hbase.index.builder.IndexBuildManager.getIndexUpdate(IndexBuildManager.java:144)
          org.apache.phoenix.hbase.index.Indexer.preBatchMutateWithExceptions(Indexer.java:324)
      Thread 169 (B.DefaultRpcServer.handler=66,queue=6,port=60020):
      

      James R. Taylor

        Attachments

        1. PHOENIX-3806.v1.patch
          6 kB
          Vincent Poon

          Issue Links

            Activity

              People

              • Assignee:
                vincentpoon Vincent Poon
                Reporter:
                larsh Lars Hofhansl
              • Votes:
                0 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: