[PHOENIX-3556] Remove usage of com.google.common.collect.Iterators.emptyIterator()

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 4.5.2
• Fix Version/s: 4.13.0

Environment

MacOs, Phoenix 4.5.2-HBase-0.98, Guava 20.0

• Assignee: Thomas D'Silva
• Reporter: Bo Gao
• Created: 03/Jan/17 08:51
• Updated: 03/Nov/17 22:18
• Resolved: 11/Oct/17 05:09

Description

I am working on a project with Google ads-lib latest version 2.22.0(Dec, 2016), and it requires Guava version 20.0(Oct, 2016). My phoneix-core version is 4.5.2-HBase-0.98. I got the following exception when trying to get Phoenix connection:

java.lang.IllegalAccessError: tried to access method com.google.common.collect.Iterators.emptyIterator()Lcom/google/common/collect/UnmodifiableIterator; from class org.apache.phoenix.schema.MetaDataClient
	at org.apache.phoenix.schema.MetaDataClient.createTableInternal(MetaDataClient.java:1501) ~[phoenix-core-4.5.2-HBase-0.98.jar:4.5.2-HBase-0.98]
	at org.apache.phoenix.schema.MetaDataClient.createTable(MetaDataClient.java:751) ~[phoenix-core-4.5.2-HBase-0.98.jar:4.5.2-HBase-0.98]
	at org.apache.phoenix.compile.CreateTableCompiler$2.execute(CreateTableCompiler.java:186) ~[phoenix-core-4.5.2-HBase-0.98.jar:4.5.2-HBase-0.98]
	at org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:315) ~[phoenix-core-4.5.2-HBase-0.98.jar:4.5.2-HBase-0.98]
	at org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:307) ~[phoenix-core-4.5.2-HBase-0.98.jar:4.5.2-HBase-0.98]
	at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53) ~[phoenix-core-4.5.2-HBase-0.98.jar:4.5.2-HBase-0.98]
	at org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:305) ~[phoenix-core-4.5.2-HBase-0.98.jar:4.5.2-HBase-0.98]
	at org.apache.phoenix.jdbc.PhoenixStatement.executeUpdate(PhoenixStatement.java:1364) ~[phoenix-core-4.5.2-HBase-0.98.jar:4.5.2-HBase-0.98]
	at org.apache.phoenix.query.ConnectionQueryServicesImpl$12.call(ConnectionQueryServicesImpl.java:1927) ~[phoenix-core-4.5.2-HBase-0.98.jar:4.5.2-HBase-0.98]
	at org.apache.phoenix.query.ConnectionQueryServicesImpl$12.call(ConnectionQueryServicesImpl.java:1896) ~[phoenix-core-4.5.2-HBase-0.98.jar:4.5.2-HBase-0.98]
	at org.apache.phoenix.util.PhoenixContextExecutor.call(PhoenixContextExecutor.java:77) ~[phoenix-core-4.5.2-HBase-0.98.jar:4.5.2-HBase-0.98]
	at org.apache.phoenix.query.ConnectionQueryServicesImpl.init(ConnectionQueryServicesImpl.java:1896) ~[phoenix-core-4.5.2-HBase-0.98.jar:4.5.2-HBase-0.98]
	at org.apache.phoenix.jdbc.PhoenixDriver.getConnectionQueryServices(PhoenixDriver.java:180) ~[phoenix-core-4.5.2-HBase-0.98.jar:4.5.2-HBase-0.98]
	at org.apache.phoenix.jdbc.PhoenixEmbeddedDriver.connect(PhoenixEmbeddedDriver.java:132) ~[phoenix-core-4.5.2-HBase-0.98.jar:4.5.2-HBase-0.98]
	at org.apache.phoenix.jdbc.PhoenixDriver.connect(PhoenixDriver.java:151) ~[phoenix-core-4.5.2-HBase-0.98.jar:4.5.2-HBase-0.98]
	at java.sql.DriverManager.getConnection(DriverManager.java:664) ~[na:1.8.0_65]
	at java.sql.DriverManager.getConnection(DriverManager.java:247) ~[na:1.8.0_65]

The issue is that from Guava 20.0 Google changed the visibility of com.google.common.collect.Iterators#emptyIterator() from public to default as it was announced earlier to be deprecated.

I checked several versions of phoenix-core from old to new, looks like all versions are using com.google.common.collect.Iterators#emptyIterator() in org.apache.phoenix.schema.MetaDataClient. So the affected versions should be all.

Better to replace the usage of emptyIterator() as https://google.github.io/guava/releases/18.0/api/docs/com/google/common/collect/Iterators.html#emptyIterator() recommends.

Issue Links

• links to: GitHub Pull Request #241