[PHOENIX-3291] Do not throw return value of Throwables#propagate call

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.9.0, 4.8.1
• Assignee: James R. Taylor
• Reporter: James R. Taylor
• Created: 17/Sep/16 01:02
• Updated: 28/Sep/16 05:15
• Resolved: 19/Sep/16 15:16

Description

Several places in the code are doing the following which is wrong:

throw Throwables.propagate(e);

This seems to get rid of any stack trace. Instead, it should be:

Throwables.propagate(e);
throw new IllegalStateException(); // won't happen as above call throws

This preserves the stack trace.