[PHOENIX-3070] Unnecessary use of UUID.randomUUID()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.8.0
• Assignee: Lars Hofhansl
• Reporter: Lars Hofhansl
• Created: 13/Jul/16 22:44
• Updated: 16/Aug/16 04:42
• Resolved: 18/Jul/16 21:14

Description

I see UUID.randomUUID() used all over Phoenix a lot.
randomUUID uses SecureRandom internally, which - on my machine - takes almost 3ms, and that is per UUID!

I don't think we need a UUIDs from a cryptographically sound random number generator.

We could do new UUID(random.nextLong(), random.nextLong()), which takes 0.06ms (60us), or even better: new UUID(ThreadLocalRandom.current().nextLong(), ThreadLocalRandom.current().nextLong()), which takes less than 0.004ms (4us) on my box.