[PHOENIX-2819] Remove problematic method ValueSchemaBuilder.addField(Field)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.7.0
• Fix Version/s: 4.8.0
• Labels: secondary_index
• Assignee: Wei Xue
• Reporter: Wei Xue
• Created: 03/Apr/16 17:32
• Updated: 11/Aug/16 08:28
• Resolved: 05/Apr/16 19:23

Description

We should discard the method "ValueSchemaBuilder.addField(Field)" and use the other method signature instead, since this method might add more fields than wanted.

        public ValueSchemaBuilder addField(Field field) {
            fields.add(field);
            return this;
        }

If field.size is larger than 1, the above statement fields.add(field) will add more than one field into the list while the caller is expecting to add only ONE.
The only caller of this method is IndexMaintainer.generateIndexRowKeySchema() and it might generate a wrong row-key-schema as a result.