Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-2819

Remove problematic method ValueSchemaBuilder.addField(Field)

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.7.0
    • Fix Version/s: 4.8.0
    • Component/s: None
    • Labels:

      Description

      We should discard the method "ValueSchemaBuilder.addField(Field)" and use the other method signature instead, since this method might add more fields than wanted.

              public ValueSchemaBuilder addField(Field field) {
                  fields.add(field);
                  return this;
              }
      

      If field.size is larger than 1, the above statement fields.add(field) will add more than one field into the list while the caller is expecting to add only ONE.
      The only caller of this method is IndexMaintainer.generateIndexRowKeySchema() and it might generate a wrong row-key-schema as a result.

        Attachments

        1. PHOENIX-2819-2.patch
          7 kB
          Wei Xue
        2. PHOENIX-2819.patch
          7 kB
          Wei Xue

          Activity

            People

            • Assignee:
              maryannxue Wei Xue
              Reporter:
              maryannxue Wei Xue
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: