[PHOENIX-2748] CsvToKeyValueMapper used by CsvBulkLoadTool should set inner PhoenixConnection autoCommit to false explicitly

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.6.0
• Fix Version/s: 4.8.0

Environment

Phoenix 4.6.0-HBase-0.98, HBase 0.98.6-cdh5.3.2

• Assignee: Gabriel Reid
• Reporter: chenglei
• Created: 05/Mar/16 05:33
• Updated: 11/Aug/16 08:29
• Resolved: 11/Mar/16 19:52

Description

CsvBulkLoadTool uses CsvToKeyValueMapper to convert csv record to KeyValues which should be inserted into target table , and CsvToKeyValueMapper gets the KeyValues by mocking upsert sql to target table,so the PhoenixConnection's autoCommit should be false,but CsvToKeyValueMapper does not set inner PhoenixConnection autoCommit to false explicitly. When we set "phoenix.connection.autoCommit" to true in hbase-site.xml,CsvToKeyValueMapper will really execute upsert sql to target table,which is not expected.

So CsvToKeyValueMapper should set inner PhoenixConnection autoCommit to false explicitly,just as PhoenixIndexImportMapper does.