Details
-
Bug
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
None
-
None
-
None
Description
Based on the improvements from PHOENIX-1973, there are a few small things that could use some touching up:
- TargetTableRefFunctions#LOGICAN_NAMES_TO_JSON appears to be spelled incorrectly (should be LOGICAL_NAMES_TO_JSON), and I don’t understand why it’s a Function instead of just a static method (it matches other Functions in that class, but the general use of Functions in that way makes no sense)
- FormatToKeyValueMapper should probably be renamed to accurately describe what it does, as well as definitely updating the class-level javadoc to explain what it does (i.e. it’s not creating KeyValues any more)
- Pretty minor code format issues, such as lack of correct spacing in FormatToKeyValueMapper#findIndex and elsewhere, and the use of wildcard imports in FormatToKeyValueMapper
- Minor nit, but why is TrustedByteArrayOutputStream being used in FormatToKeyValueMapper#writeAggregatedRow?