[PHOENIX-2733] Minor cleanup for improvements to CSV Bulk Loader performance

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.7.0
• Assignee: Sergey Soldatov
• Reporter: Gabriel Reid
• Created: 02/Mar/16 18:33
• Updated: 03/Mar/16 00:23
• Resolved: 02/Mar/16 22:03

Description

Based on the improvements from PHOENIX-1973, there are a few small things that could use some touching up:

• TargetTableRefFunctions#LOGICAN_NAMES_TO_JSON appears to be spelled incorrectly (should be LOGICAL_NAMES_TO_JSON), and I don’t understand why it’s a Function instead of just a static method (it matches other Functions in that class, but the general use of Functions in that way makes no sense)
• FormatToKeyValueMapper should probably be renamed to accurately describe what it does, as well as definitely updating the class-level javadoc to explain what it does (i.e. it’s not creating KeyValues any more)
• Pretty minor code format issues, such as lack of correct spacing in FormatToKeyValueMapper#findIndex and elsewhere, and the use of wildcard imports in FormatToKeyValueMapper
• Minor nit, but why is TrustedByteArrayOutputStream being used in FormatToKeyValueMapper#writeAggregatedRow?