[PHOENIX-2531] Phoenix thin-client jar has incorrect META-INF/services/java.sql.Driver file

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 4.7.0
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 15/Dec/15 21:59
• Updated: 16/Dec/15 04:04
• Resolved: 15/Dec/15 23:58

Description

Trying to hook up the thin-client to pherf, I was having some troubles with being unable to find the thin-client Driver. I knew that we should be getting it loaded by the service definition contained in the jar META-INF/services/java.sql.Driver.

Upon inspection of the "normal" jar produced by phoenix-server-client, the contents of the file were as we expect org.apache.phoenix.queryserver.client.Driver. However, the top-level "thin-client" jar we bundle in the tarball had a value of org.apache.calcite.avatica.remote.Driver instead.

It seems like when we built phoenix-$VERSION-thin-client.jar (jar-with-dependencies is all it is, really), Avatica's META-INF/services/java.sql.Driver was overwriting the copy we had in phoenix-server-client/src/main/resources. I'm not sure how/why we didn't notice this yet (for example, why did sqlline-thin.py work?), but it's definitely busted for how it should work.

It's a simple enough fix to explicitly set the file in the assembly descriptor.