Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-2058

Check for existence and compatibility of columns being added in view

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5.0
    • Labels:

      Description

      One check I realized we're not doing, but need to do, is ensuring that the column being added by the base table doesn't already exist in the view. If the column does already exist, ideally we can allow the addition to the base table if the type matches and the scale is null or >= existing scale and the maxLength is null or >= existing maxLength. Also, if a column is a PK column and it already exists in the view, the position in the PK must match.

      The fact that we've materialized a PTable for the view should make the addition of this check easier.

        Attachments

        1. PHOENIX-2058-WIP.patch
          18 kB
          Thomas D'Silva
        2. PHOENIX-2058.wip.2.patch
          20 kB
          Thomas D'Silva
        3. PHOENIX-2058.v2.patch
          26 kB
          Thomas D'Silva
        4. PHOENIX-2058.patch
          30 kB
          Thomas D'Silva
        5. PHOENIX-2058.final.patch
          30 kB
          Thomas D'Silva

          Activity

            People

            • Assignee:
              tdsilva Thomas D'Silva
              Reporter:
              jamestaylor James Taylor
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: