Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-2022

BaseRegionScanner.next should be abstract

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.5.0, 4.4.1
    • None
    • None

    Description

      As pointed out by Yuhao Bi on a dev list mail, BaseRegionScanner implements next as a recursive call to itself.

      All current subclasses of BaseRegionScanner implement next, but as soon as there is an implementation that doesn't do this, it will end up with a stack overflow.

      Easy fix is to make this method abstract instead of having a default recursive implementation.

      Attachments

        1. PHOENIX-2022.patch
          1 kB
          Gabriel Reid

        Activity

          People

            gabriel.reid Gabriel Reid
            gabriel.reid Gabriel Reid
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: