Uploaded image for project: 'Phoenix'
  1. Phoenix
  2. PHOENIX-1642

Make Phoenix Master Branch pointing to HBase1.0.0

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.4.0
    • Labels:
      None

      Description

      As HBase1.0.0 will soon be released, the JIRA is to point Phoenix master branch to HBase1.0.0 release. Once we reach consensus, we could also port the changes into Phoenix 4.0 branch as well which can be done in a separate JIRA.

      1. PHOENIX-1642.patch
        137 kB
        Jeffrey Zhong
      2. 1642-1.txt
        99 kB
        Devaraj Das
      3. 1642-toRemove.patch
        3 kB
        James Taylor
      4. 1642-toRemove2.txt
        2 kB
        James Taylor
      5. 1642-2.txt
        94 kB
        James Taylor
      6. phoenix-1642_v3.patch
        98 kB
        Enis Soztutar

        Issue Links

          Activity

          Hide
          enis Enis Soztutar added a comment -

          Bulk close of all issues that has been resolved in a released version.

          Show
          enis Enis Soztutar added a comment - Bulk close of all issues that has been resolved in a released version.
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Phoenix-master #638 (See https://builds.apache.org/job/Phoenix-master/638/)
          PHOENIX-1642 Make Phoenix Master Branch pointing to HBase1.0.0 - ADDENDUM for HBASE-13109 (enis: rev ad2ad0cefd5d19a9bc84345444455a9ecbb55c78)

          • phoenix-core/src/main/java/org/apache/phoenix/hbase/index/scanner/FilteredKeyValueScanner.java
          • phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReader.java
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Phoenix-master #638 (See https://builds.apache.org/job/Phoenix-master/638/ ) PHOENIX-1642 Make Phoenix Master Branch pointing to HBase1.0.0 - ADDENDUM for HBASE-13109 (enis: rev ad2ad0cefd5d19a9bc84345444455a9ecbb55c78) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/scanner/FilteredKeyValueScanner.java phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReader.java
          Hide
          enis Enis Soztutar added a comment -

          I've created the 4.x-HBase-1.0 branch and pushed this to there as well. The jenkins builds succeeded at least once (see the dev thread for details).

          I forgot to give credits in the commit message. Thanks Jeffrey, James and Devaraj for different versions of the patch.

          Show
          enis Enis Soztutar added a comment - I've created the 4.x-HBase-1.0 branch and pushed this to there as well. The jenkins builds succeeded at least once (see the dev thread for details). I forgot to give credits in the commit message. Thanks Jeffrey, James and Devaraj for different versions of the patch.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Phoenix-master #626 (See https://builds.apache.org/job/Phoenix-master/626/)
          PHOENIX-1642 Make Phoenix Master Branch pointing to HBase1.0.0 (enis: rev c98cda7e11a9a8f551d891fbc8b8088981db2007)

          • phoenix-flume/pom.xml
          • phoenix-core/src/it/java/org/apache/phoenix/trace/PhoenixTracingEndToEndIT.java
          • phoenix-core/pom.xml
          • phoenix-core/src/main/java/org/apache/phoenix/hbase/index/balancer/IndexLoadBalancer.java
          • phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java
          • phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/LocalIndexMerger.java
          • phoenix-core/src/it/java/org/apache/phoenix/hbase/index/balancer/IndexLoadBalancerIT.java
          • phoenix-core/src/test/java/org/apache/phoenix/hbase/index/write/recovery/TestPerRegionIndexWriteCache.java
          • phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java
          • phoenix-core/src/main/java/org/apache/phoenix/trace/TracingIterator.java
          • phoenix-core/src/main/java/org/apache/phoenix/hbase/index/scanner/Scanner.java
          • phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/data/IndexMemStore.java
          • phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/data/LazyValueGetter.java
          • phoenix-core/src/test/java/org/apache/hadoop/hbase/regionserver/PhoenixIndexRpcSchedulerFactoryTest.java
          • phoenix-core/src/main/java/org/apache/phoenix/trace/TracingUtils.java
          • phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/update/ColumnReference.java
          • phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/LocalIndexSplitter.java
          • phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
          • phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java
          • phoenix-core/src/main/java/org/apache/phoenix/trace/TraceMetricSource.java
          • phoenix-core/src/main/java/org/apache/phoenix/hbase/index/scanner/FilteredKeyValueScanner.java
          • phoenix-core/src/it/java/org/apache/hadoop/hbase/regionserver/wal/WALReplayWithIndexWritesAndCompressedWALIT.java
          • phoenix-core/src/test/java/org/apache/phoenix/hbase/index/write/TestWALRecoveryCaching.java
          • phoenix-core/src/it/java/org/apache/phoenix/end2end/index/LocalIndexIT.java
          • phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/TestLocalTableState.java
          • phoenix-core/src/main/java/org/apache/phoenix/trace/TraceReader.java
          • phoenix-core/src/test/java/org/apache/hadoop/hbase/ipc/PhoenixIndexRpcSchedulerTest.java
          • phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/data/TestIndexMemStore.java
          • phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java
          • phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java
          • pom.xml
          • phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReader.java
          • phoenix-core/src/it/java/org/apache/phoenix/trace/PhoenixTraceReaderIT.java
          • phoenix-core/src/main/java/org/apache/phoenix/hbase/index/wal/IndexedKeyValue.java
          • phoenix-core/src/main/java/org/apache/phoenix/hbase/index/ipc/PhoenixIndexRpcSchedulerFactory.java
          • phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexSplitTransaction.java
          • phoenix-core/src/main/java/org/apache/phoenix/execute/BaseQueryPlan.java
          • phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/filter/ApplyAndFilterDeletesFilter.java
          • phoenix-core/src/main/java/org/apache/phoenix/trace/util/NullSpan.java
          • phoenix-core/src/main/java/org/apache/phoenix/trace/util/Tracing.java
          • phoenix-core/src/main/java/org/apache/phoenix/compile/TraceQueryPlan.java
          • phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/example/CoveredColumnIndexCodec.java
          • phoenix-assembly/src/build/client.xml
          • phoenix-core/src/test/java/org/apache/phoenix/trace/TraceMetricsSourceTest.java
          • phoenix-core/src/main/java/org/apache/phoenix/hbase/index/scanner/ScannerBuilder.java
          • phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueSkipListSet.java
          • phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Phoenix-master #626 (See https://builds.apache.org/job/Phoenix-master/626/ ) PHOENIX-1642 Make Phoenix Master Branch pointing to HBase1.0.0 (enis: rev c98cda7e11a9a8f551d891fbc8b8088981db2007) phoenix-flume/pom.xml phoenix-core/src/it/java/org/apache/phoenix/trace/PhoenixTracingEndToEndIT.java phoenix-core/pom.xml phoenix-core/src/main/java/org/apache/phoenix/hbase/index/balancer/IndexLoadBalancer.java phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/LocalIndexMerger.java phoenix-core/src/it/java/org/apache/phoenix/hbase/index/balancer/IndexLoadBalancerIT.java phoenix-core/src/test/java/org/apache/phoenix/hbase/index/write/recovery/TestPerRegionIndexWriteCache.java phoenix-core/src/main/java/org/apache/phoenix/util/IndexUtil.java phoenix-core/src/main/java/org/apache/phoenix/trace/TracingIterator.java phoenix-core/src/main/java/org/apache/phoenix/hbase/index/scanner/Scanner.java phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/data/IndexMemStore.java phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/data/LazyValueGetter.java phoenix-core/src/test/java/org/apache/hadoop/hbase/regionserver/PhoenixIndexRpcSchedulerFactoryTest.java phoenix-core/src/main/java/org/apache/phoenix/trace/TracingUtils.java phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/update/ColumnReference.java phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/LocalIndexSplitter.java phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java phoenix-core/src/main/java/org/apache/phoenix/trace/TraceMetricSource.java phoenix-core/src/main/java/org/apache/phoenix/hbase/index/scanner/FilteredKeyValueScanner.java phoenix-core/src/it/java/org/apache/hadoop/hbase/regionserver/wal/WALReplayWithIndexWritesAndCompressedWALIT.java phoenix-core/src/test/java/org/apache/phoenix/hbase/index/write/TestWALRecoveryCaching.java phoenix-core/src/it/java/org/apache/phoenix/end2end/index/LocalIndexIT.java phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/TestLocalTableState.java phoenix-core/src/main/java/org/apache/phoenix/trace/TraceReader.java phoenix-core/src/test/java/org/apache/hadoop/hbase/ipc/PhoenixIndexRpcSchedulerTest.java phoenix-core/src/test/java/org/apache/phoenix/hbase/index/covered/data/TestIndexMemStore.java phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java pom.xml phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReader.java phoenix-core/src/it/java/org/apache/phoenix/trace/PhoenixTraceReaderIT.java phoenix-core/src/main/java/org/apache/phoenix/hbase/index/wal/IndexedKeyValue.java phoenix-core/src/main/java/org/apache/phoenix/hbase/index/ipc/PhoenixIndexRpcSchedulerFactory.java phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexSplitTransaction.java phoenix-core/src/main/java/org/apache/phoenix/execute/BaseQueryPlan.java phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/filter/ApplyAndFilterDeletesFilter.java phoenix-core/src/main/java/org/apache/phoenix/trace/util/NullSpan.java phoenix-core/src/main/java/org/apache/phoenix/trace/util/Tracing.java phoenix-core/src/main/java/org/apache/phoenix/compile/TraceQueryPlan.java phoenix-core/src/main/java/org/apache/phoenix/hbase/index/covered/example/CoveredColumnIndexCodec.java phoenix-assembly/src/build/client.xml phoenix-core/src/test/java/org/apache/phoenix/trace/TraceMetricsSourceTest.java phoenix-core/src/main/java/org/apache/phoenix/hbase/index/scanner/ScannerBuilder.java phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueSkipListSet.java phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java
          Hide
          enis Enis Soztutar added a comment -

          I've committed this to master. Keeping it open for 4.4 until branching is complete.

          Show
          enis Enis Soztutar added a comment - I've committed this to master. Keeping it open for 4.4 until branching is complete.
          Hide
          enis Enis Soztutar added a comment -

          Here is a rebased patch that applies to master based on v2 patch from James Taylor. There are two changes:

          • Construction of ProbabilitySampler
          • HBase dependency is moved to 1.0.1-SNAPSHOT. PhoenixTracingEndToEndIT works with this version which I published to the apache snapshot maven repository. I'll create another issue to move to 1.0.1 when it is released.
          Show
          enis Enis Soztutar added a comment - Here is a rebased patch that applies to master based on v2 patch from James Taylor . There are two changes: Construction of ProbabilitySampler HBase dependency is moved to 1.0.1-SNAPSHOT. PhoenixTracingEndToEndIT works with this version which I published to the apache snapshot maven repository. I'll create another issue to move to 1.0.1 when it is released.
          Hide
          devaraj Devaraj Das added a comment -

          I am okay with the patch James Taylor. Thanks. We need to resolve the branch discussion now to commit this patch..

          Show
          devaraj Devaraj Das added a comment - I am okay with the patch James Taylor . Thanks. We need to resolve the branch discussion now to commit this patch..
          Hide
          jamestaylor James Taylor added a comment -

          Yes, that was intentional as it should not be necessary.

          Show
          jamestaylor James Taylor added a comment - Yes, that was intentional as it should not be necessary.
          Hide
          devaraj Devaraj Das added a comment -

          James Taylor did a cursory check of the diffs w.r.t what I submitted on Jeffrey Zhong's rebased patch. I see you removed BaseTest.java in the patch you last submitted. But in Jeffrey's original patch, there was a

          +            conn.commit();
          

          which is missing from the BaseTest.java committed in the master branch thus far. Just wondering if that is deliberate...

          Show
          devaraj Devaraj Das added a comment - James Taylor did a cursory check of the diffs w.r.t what I submitted on Jeffrey Zhong 's rebased patch. I see you removed BaseTest.java in the patch you last submitted. But in Jeffrey's original patch, there was a + conn.commit(); which is missing from the BaseTest.java committed in the master branch thus far. Just wondering if that is deliberate...
          Hide
          jamestaylor James Taylor added a comment -

          Here's the final patch (minus the files I was able to update in both 4.0 & master), Devaraj Das.

          Show
          jamestaylor James Taylor added a comment - Here's the final patch (minus the files I was able to update in both 4.0 & master), Devaraj Das .
          Hide
          jamestaylor James Taylor added a comment -

          One more change, the one to BaseTest isn't necessary. This file also changes frequently, so if we can keep it the same, that'll make life easier. We can just use the property attribute name directly as it's the same (only the name of the HConstant changed).

          Also, Jeffrey Zhong - the commit you added after the DROP SEQUENCE calls isn't necessary. Is the setting of the QueryServices.QUEUE_SIZE_ATTRIB necessary as that seems somewhat random.

          Show
          jamestaylor James Taylor added a comment - One more change, the one to BaseTest isn't necessary. This file also changes frequently, so if we can keep it the same, that'll make life easier. We can just use the property attribute name directly as it's the same (only the name of the HConstant changed). Also, Jeffrey Zhong - the commit you added after the DROP SEQUENCE calls isn't necessary. Is the setting of the QueryServices.QUEUE_SIZE_ATTRIB necessary as that seems somewhat random.
          Hide
          jamestaylor James Taylor added a comment -

          A few more of these changes can be applied to 4.0. The change to SingleKeyValueComparisonFilter.java is just a bug - that should be applied everywhere. Also the change to MetaDataClient looks ok for 4.0 & master and since this file changes frequently, it'd be good to keep them the same if possible.

          I'll commit these changes to 4.0 and the SingleKeyValueComparisonFilter change to 4.3. If you just remove those diffs from your patch, your patch should apply fine.

          +1 after that.

          Show
          jamestaylor James Taylor added a comment - A few more of these changes can be applied to 4.0. The change to SingleKeyValueComparisonFilter.java is just a bug - that should be applied everywhere. Also the change to MetaDataClient looks ok for 4.0 & master and since this file changes frequently, it'd be good to keep them the same if possible. I'll commit these changes to 4.0 and the SingleKeyValueComparisonFilter change to 4.3. If you just remove those diffs from your patch, your patch should apply fine. +1 after that.
          Hide
          jeffreyz Jeffrey Zhong added a comment -

          Thanks Devaraj Das for taking this forward! Looks good to me for your rebased patch(+1). One minor thing that we can point to 1.0.1-SNAPSHOT hbase version so that end to end trace test can pass.

          +    <hbase.version>1.0.0</hbase.version>
          
          Show
          jeffreyz Jeffrey Zhong added a comment - Thanks Devaraj Das for taking this forward! Looks good to me for your rebased patch(+1). One minor thing that we can point to 1.0.1-SNAPSHOT hbase version so that end to end trace test can pass. + <hbase.version>1.0.0</hbase.version>
          Hide
          devaraj Devaraj Das added a comment -

          This is Jeffrey Zhong's rebased patch.

          Show
          devaraj Devaraj Das added a comment - This is Jeffrey Zhong 's rebased patch.
          Hide
          jeffreyz Jeffrey Zhong added a comment -

          Let's not go with shim layer which no one likes it and needs extra clean up if we want to retire some code. In addition, merging code effort isn't less when dealing with release differences.

          For branching, we can check the patch into Master branch and then branch a new branch 4.x-hbase-1.0 from master. HBase1.1 will compatible with HBase1.0 but not have to be with 0.98.. Therefore, this branch will support HBase1. line with more HBase1.* interfaces & features not in 0.98.

          Show
          jeffreyz Jeffrey Zhong added a comment - Let's not go with shim layer which no one likes it and needs extra clean up if we want to retire some code. In addition, merging code effort isn't less when dealing with release differences. For branching, we can check the patch into Master branch and then branch a new branch 4.x-hbase-1.0 from master. HBase1.1 will compatible with HBase1.0 but not have to be with 0.98. . Therefore, this branch will support HBase1. line with more HBase1.* interfaces & features not in 0.98.
          Hide
          enis Enis Soztutar added a comment -

          I have pushed 1.0.1-SNAPSHOT to the maven snapshot repositories BTW. You can depend on it for the failed unit test. Once 1.0.1 is released, we can then change it to be 1.0.1 and drop the snapshot.

          For the branches, I like the model of having phoenix releases with the same set of features, but for different versions of HBase. It may mean 1 branch per supported HBase branch if we are not doing shims.
          Whether use 5.x or 4.x-hbase-1.0 is a matter of how frequent we want to bump major versions I think. HBase is expected to release 1.1, 1.2, etc and even in best case, I expect some minor changes that may need a shim or a different branch between 1.x releases.

          Show
          enis Enis Soztutar added a comment - I have pushed 1.0.1-SNAPSHOT to the maven snapshot repositories BTW. You can depend on it for the failed unit test. Once 1.0.1 is released, we can then change it to be 1.0.1 and drop the snapshot. For the branches, I like the model of having phoenix releases with the same set of features, but for different versions of HBase. It may mean 1 branch per supported HBase branch if we are not doing shims. Whether use 5.x or 4.x-hbase-1.0 is a matter of how frequent we want to bump major versions I think. HBase is expected to release 1.1, 1.2, etc and even in best case, I expect some minor changes that may need a shim or a different branch between 1.x releases.
          Hide
          jamestaylor James Taylor added a comment -

          Since it seems that going from 0.98 -> 1.0 does not require any downtime plus 0.98 clients will work with 1.0 clients, Phoenix support for 1.0 will not require a major Phoenix release. Should we commit this patch in a different branch? What will our naming scheme be between Phoenix releases for HBase 1.0 versus HBase 0.98? Should we have a 4.4 release for HBase 0.98 and a 5.4 release for HBase 1.0? Or should we call in 4.4-HBase-0.98 and 4.4-HBase-1.0 (or some other, better names)? Or should we have a shim layer, as these changes look pretty minimal?

          Also, what would the timing of a Phoenix on top of HBase 1.0 release be? Are users waiting for this - I've seen one request so far on the mailing list? How long will development continue on the 0.98 branch? In what branch would we put Phoenix features that will require a major upgrade? If we put these in the master branch, and the master branch is solely for HBase 1.0, what happens if we want to release a Phoenix major release on the 0.98 branch?

          Show
          jamestaylor James Taylor added a comment - Since it seems that going from 0.98 -> 1.0 does not require any downtime plus 0.98 clients will work with 1.0 clients, Phoenix support for 1.0 will not require a major Phoenix release. Should we commit this patch in a different branch? What will our naming scheme be between Phoenix releases for HBase 1.0 versus HBase 0.98? Should we have a 4.4 release for HBase 0.98 and a 5.4 release for HBase 1.0? Or should we call in 4.4-HBase-0.98 and 4.4-HBase-1.0 (or some other, better names)? Or should we have a shim layer, as these changes look pretty minimal? Also, what would the timing of a Phoenix on top of HBase 1.0 release be? Are users waiting for this - I've seen one request so far on the mailing list? How long will development continue on the 0.98 branch? In what branch would we put Phoenix features that will require a major upgrade? If we put these in the master branch, and the master branch is solely for HBase 1.0, what happens if we want to release a Phoenix major release on the 0.98 branch?
          Hide
          jeffreyz Jeffrey Zhong added a comment -

          PhoenixTracingEndToEndIT will fail due to HBASE-13077. Hopefully Enis Soztutar will release 1.0.1 soon after 1.0 is released for us to point HBase 1.0.1.

          Show
          jeffreyz Jeffrey Zhong added a comment - PhoenixTracingEndToEndIT will fail due to HBASE-13077 . Hopefully Enis Soztutar will release 1.0.1 soon after 1.0 is released for us to point HBase 1.0.1.
          Hide
          jamestaylor James Taylor added a comment -

          Ok, good to know. So this seems like it won't necessitate a major release on the part of Phoenix.

          Show
          jamestaylor James Taylor added a comment - Ok, good to know. So this seems like it won't necessitate a major release on the part of Phoenix.
          Hide
          jeffreyz Jeffrey Zhong added a comment -

          Phoenix 4.x server jar for sure doesn't work with HBase1.0.

          Phoenix 4.x client seems can work on Phoenix master running on top of HBase1.0. The only thing might be broken I could think of is the htrace because we switch its package to Apache on HBase1.0 but I didn't test that scenario.

          Show
          jeffreyz Jeffrey Zhong added a comment - Phoenix 4.x server jar for sure doesn't work with HBase1.0. Phoenix 4.x client seems can work on Phoenix master running on top of HBase1.0. The only thing might be broken I could think of is the htrace because we switch its package to Apache on HBase1.0 but I didn't test that scenario.
          Hide
          jamestaylor James Taylor added a comment -

          Thanks, Jeffrey Zhong. That's good news. Would 4.x Phoenix clients work against a cluster running HBase 1.0 still, or would that not be possible?

          Show
          jamestaylor James Taylor added a comment - Thanks, Jeffrey Zhong . That's good news. Would 4.x Phoenix clients work against a cluster running HBase 1.0 still, or would that not be possible?
          Hide
          jeffreyz Jeffrey Zhong added a comment -

          I've ported Phoenix master branch on top of HBase1.0. Once HBase1.0 is officially released, I'll post the patch soon after.

          Show
          jeffreyz Jeffrey Zhong added a comment - I've ported Phoenix master branch on top of HBase1.0. Once HBase1.0 is officially released, I'll post the patch soon after.
          Hide
          jeffreyz Jeffrey Zhong added a comment -

          Agree both of you. In 4.0 line supporting both HBase 0.98.* and 1.* version is hardly to avoid shim layer which no one like it. That subjects to consensus. This JIRA is only scoped to point master branch to HBase version 1.0.0.

          Show
          jeffreyz Jeffrey Zhong added a comment - Agree both of you. In 4.0 line supporting both HBase 0.98.* and 1.* version is hardly to avoid shim layer which no one like it. That subjects to consensus. This JIRA is only scoped to point master branch to HBase version 1.0.0.
          Hide
          jamestaylor James Taylor added a comment -

          Agree. Let's keep 4.0 line compatible with 0.98.

          Show
          jamestaylor James Taylor added a comment - Agree. Let's keep 4.0 line compatible with 0.98.
          Hide
          apurtell Andrew Purtell added a comment - - edited

          we could also port the changes into Phoenix 4.0 branch as well which can be done in a separate JIRA.

          How does this work when 4.0 must be compat with 0.98? I'm assuming we are not going to abandon users with 0.98+Phoenix 4 in the middle of the version 4 release line.

          Show
          apurtell Andrew Purtell added a comment - - edited we could also port the changes into Phoenix 4.0 branch as well which can be done in a separate JIRA. How does this work when 4.0 must be compat with 0.98? I'm assuming we are not going to abandon users with 0.98+Phoenix 4 in the middle of the version 4 release line.

            People

            • Assignee:
              devaraj Devaraj Das
              Reporter:
              jeffreyz Jeffrey Zhong
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development