[PHOENIX-1396] Avoid unnecessary ResultSpooler.bin files creation/deletion every time SpoolingResultIterator is used

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0
• Fix Version/s: 4.3.0, 3.3.0, 4.2.1
• Assignee: Jeffrey Zhong
• Reporter: Jeffrey Zhong
• Created: 31/Oct/14 16:46
• Updated: 21/Nov/15 02:17
• Resolved: 05/Nov/14 18:02

Description

In SpoolingResultIterator.java, we have following code:

            tempFile = File.createTempFile("ResultSpooler",".bin", new File(spoolDirectory));
            DeferredFileOutputStream spoolTo = new DeferredFileOutputStream(size, tempFile) {

Basically we pre-create spill file even we don't reach memory threshold and later we delete the same file if it's not needed in finally block. We can remove these unnecessary file creation & deletion altogether.