[PHOENIX-1163] Intersect min/max range with scan range during compilation when salted

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.2.0, 3.2.0
• Assignee: James R. Taylor
• Reporter: James R. Taylor
• Created: 12/Aug/14 18:18
• Updated: 21/Nov/15 02:17
• Resolved: 21/Oct/14 20:25

Description

There's some hacky code in ParallelIterators that can be removed if we intersect the scan range earlier, during compilation. See this FIXME:

            if (tableRef.getTable().getBucketNum() != null) {
                KeyRange minMaxRange = context.getMinMaxRange();
                if (minMaxRange != null) {
                    // Add salt byte based on current split, as minMaxRange won't have it
                    minMaxRange = SaltingUtil.addSaltByte(split.getLowerRange(), minMaxRange);
                    // FIXME: seems like this should be possible when we set the scan start/stop
                    // in StatementContext.setScanRanges(). If it doesn't intersect the range for
                    // one salt byte, I don't see how it could intersect it with any of them.
                    if (!ScanUtil.intersectScanRange(splitScan, minMaxRange.getLowerRange(), minMaxRange.getUpperRange())) {
                        continue; // Skip this chunk if no intersection based on minMaxRange
                    }
                }
            }