[PDFBOX-628] Too many detours in COSDictionary convenience methods

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Component/s: PDModel
• Assignee: Unassigned
• Reporter: Johannes Koch
• Created: 22/Feb/10 12:54
• Updated: 08/Mar/10 08:56
• Resolved: 07/Mar/10 16:06

Description

I think there are too many detours in some of the COSDictionary convenience methods. E.g.

getInt( COSName key )
-> getInt( COSName key, int defaultValue )
// create String from COSName
-> getInt( String key, int defaultValue )
-> getInt( String[] keyList, int defaultValue )
-> getDictionaryObject( String[] keyList )
// create COSName from String
-> getDictionaryObject( COSName key )

Wouldn't it be easier to just do the following?

getInt( COSName key )
-> getDictionaryObject( COSName key )

Same with getLong(COSName):

getLong( COSName key )
-> getLong( COSName key, long defaultValue )
-> getLong( String key, long defaultValue )
-> getLong( String[] keyList, long defaultValue )
-> getDictionaryObject( String[] keyList )
-> getDictionaryObject( COSName key )

This could be reduced to:

getLong( COSName key )
-> getDictionaryObject( COSName key )

getFloat(COSName) has only one detour:

getFloat( COSName key )
-> getFloat( COSName key, float defaultValue )
-> getDictionaryObject( COSName key )

This could be reduced to:

getFloat( COSName key )
-> getDictionaryObject( COSName key )