Uploaded image for project: 'PDFBox'
  1. PDFBox
  2. PDFBOX-628

Too many detours in COSDictionary convenience methods

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0
    • Component/s: PDModel
    • Labels:
      None

      Description

      I think there are too many detours in some of the COSDictionary convenience methods. E.g.

      getInt( COSName key )
      -> getInt( COSName key, int defaultValue )
      // create String from COSName
      -> getInt( String key, int defaultValue )
      -> getInt( String[] keyList, int defaultValue )
      -> getDictionaryObject( String[] keyList )
      // create COSName from String
      -> getDictionaryObject( COSName key )

      Wouldn't it be easier to just do the following?

      getInt( COSName key )
      -> getDictionaryObject( COSName key )

      Same with getLong(COSName):

      getLong( COSName key )
      -> getLong( COSName key, long defaultValue )
      -> getLong( String key, long defaultValue )
      -> getLong( String[] keyList, long defaultValue )
      -> getDictionaryObject( String[] keyList )
      -> getDictionaryObject( COSName key )

      This could be reduced to:

      getLong( COSName key )
      -> getDictionaryObject( COSName key )

      getFloat(COSName) has only one detour:

      getFloat( COSName key )
      -> getFloat( COSName key, float defaultValue )
      -> getDictionaryObject( COSName key )

      This could be reduced to:

      getFloat( COSName key )
      -> getDictionaryObject( COSName key )

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              waldbaer Johannes Koch
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: