[PDFBOX-5703] use comparison operators for enums

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0 PDFBox
• Fix Version/s: 2.0.30, 3.0.1 PDFBox, 4.0.0
• Labels: patch
• Flags: Patch
• Assignee: Tilman Hausherr
• Reporter: Axel Howind
• Created: 19/Oct/23 12:53
• Updated: 05/Nov/23 11:33
• Resolved: 22/Oct/23 14:33

Description

PDFBox code base in some places uses equals() to test for enum equality. This is unnecessary since enum values are guaranteed to be unique. This patch replaces calls to equals() with comparison operators, which IMHO makes the code easier to read. Comparison using == / != is null safe too, so there should nothing to worry about.