[PDFBOX-4665] PDImageXObject createFromFileByExtension does not close FileInputStream in event of error

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.17
• Fix Version/s: 2.0.18
• Component/s: PDModel
• Assignee: Tilman Hausherr
• Reporter: Chris Cockayne
• Created: 08/Oct/19 08:54
• Updated: 23/Dec/19 22:16
• Resolved: 08/Oct/19 16:14

Description

if you pass a mislabelled jpeg image file to PDImageXObject.createFromFileByExtension, e.g. a png image that is incorrectly named foo.jpg, then the file is treated as a JPEG. A FileInputStream is opened and JPEGFactory.createFromStream then (correctly) throws an IIOException. However, the FileInputStream is not closed.

I saw that this is fixed in 3.0.0-SNAPSHOT:

if ("jpg".equals(ext) || "jpeg".equals(ext))

{

try (FileInputStream fis = new FileInputStream(file))

{ return JPEGFactory.createFromStream(doc, fis); }

}

 

but if another 2.0.x release is made it would be good to include this.