[PDFBOX-3605] Infinite Read Loop in BufferedRandomAccesssFile

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.3
• Fix Version/s: 2.0.4, 3.0.0 PDFBox
• Component/s: FontBox
• External issue URL: https://github.com/apache/pdfbox/pull/31
• Assignee: Tilman Hausherr
• Reporter: Cameron Rollheiser
• Created: 29/Nov/16 16:49
• Updated: 25/Mar/17 18:13
• Resolved: 29/Nov/16 18:16

Description

When reading an input file using the BufferedRandomAccesssFile an infinite loop will occur once the buffer is drained and the value leftover becomes 0, since the read method will continue to return 0 as the -1 result from fillBuffer() is never propagated upstream and any code that is executing in a loop using -1 as an indicator that the file has been fully read will never exit.

An example of where this occurs can be found here:

https://github.com/apache/pdfbox/blob/782ac20dcea7b2e5bb6848f4da9a68c00b4d69a3/fontbox/src/main/java/org/apache/fontbox/ttf/TTFDataStream.java#L264