[PDFBOX-3354] PDCIDFont.getAverageFontWidth always returns 0

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.1, 2.0.2, 3.0.0 PDFBox
• Fix Version/s: 2.0.2, 3.0.0 PDFBox
• Assignee: Tilman Hausherr
• Reporter: Gabriel Carabas
• Created: 19/May/16 08:45
• Updated: 25/Mar/17 18:12
• Resolved: 19/May/16 18:36

Description

PDCIDFont.getAverageFontWidth method is using the field averageWidth as a cache, but fails to update its contents. Instead all the calculations go into a local variable with identical name,

PDCIDFont.java

    public float getAverageFontWidth()
    {
        if (averageWidth == 0)
        {
            float totalWidths = 0.0f;
            float characterCount = 0.0f;
            if (widths != null)
            {
                characterCount = widths.size();
                Collection<Float> widthsValues = widths.values();
                for (Float width : widthsValues)
                {
                    totalWidths += width;
                }
            }
            float averageWidth = totalWidths / characterCount;
            if (averageWidth <= 0 || Float.isNaN(averageWidth))
            {
                averageWidth = getDefaultWidth();
            }
        }
        return averageWidth;
    }

A potential fix is the removal of the local variable declaration.

float averageWidth = totalWidths / characterCount;