[PDFBOX-1831] [PATCH] Fix: "Foreign" characters are not rendered

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: FontBox
• Labels: Breaking-Change patch
• Assignee: Andreas Lehmkühler
• Reporter: John Hewson
• Created: 05/Jan/14 05:16
• Updated: 17/Mar/16 19:08
• Resolved: 05/Jan/14 15:42

Description

This is a patch to fix PDFBOX-1691, I've opened it as its own issue because it's quite a large patch.

The issue it fixes is that the Type 1 "seac" command was not implemented. Seac is a command which draws a composite glyph from two other glyphs. This requires that the Type 1 renderer has access to any of the other rendered glyphs in a CFFFont, which is why this patch is non-trivial. The major change is that the CharStringRenderer has been refactored into a new Type1CharString class and the CharStringConverter has been refactored into a new Type2CharString class. A lot of code has been moved around, but overall this is a conservative patch, as most of the code has not changed significantly.

As well as the patch, there are 3 new files:

+ fontbox/src/main/java/org/apache/fontbox/cff/Type1CharString.java
+ fontbox/src/main/java/org/apache/fontbox/cff/Type2CharString.java
+ fontbox/src/main/java/org/apache/fontbox/encoding/StandardEncoding.java

and two deleted files:

• fontbox/src/main/java/org/apache/fontbox/cff/CharStringRenderer.java
• fontbox/src/main/java/org/apache/fontbox/cff/CharStringConverter.java

Issue Links

• is depended upon by: PDFBOX-1691 "Foreign" characters are not rendered